From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399AbbE0KIg (ORCPT ); Wed, 27 May 2015 06:08:36 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:35578 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbE0KId (ORCPT ); Wed, 27 May 2015 06:08:33 -0400 Date: Wed, 27 May 2015 11:08:31 +0100 From: Charles Keepax To: Lee Jones Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: arizona: Add DT/ACPI u32 helper functions Message-ID: <20150527100831.GE31187@opensource.wolfsonmicro.com> References: <1432546115-5685-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1432546115-5685-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150527092440.GB11677@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150527092440.GB11677@x1> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 10:24:40AM +0100, Lee Jones wrote: > On Mon, 25 May 2015, Charles Keepax wrote: > > > Add helpers to read u32's and arrays of u32's from device tree or ACPI > > using the new device properties API. > > > > Signed-off-by: Charles Keepax > > --- > > drivers/mfd/arizona-core.c | 39 ++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/arizona/core.h | 5 ++++ > > 2 files changed, 44 insertions(+), 0 deletions(-) > > Me no likey! > > There are 100's of 'required' and 'optional' properties in the kernel > and it's normally the decision to early return or not that seals the > fate of a given driver. I'm not happy for platforms to start adding > their own variants. > > If you really do think these kinds of "helpers" add value, then make > them generic, so everyone can make use of them. Personally, I'm > dubious however. Thats cool I don't really have any problem with dropping this patch and doing the necessary checking where appropriate. Thanks, Charles