From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751906AbbE0KXm (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 06:23:42 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:38572 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751234AbbE0KXj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 06:23:39 -0400
Date: Wed, 27 May 2015 11:23:34 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 2/9] mfd: max77693: Store I2C device type as enum and
 add default unknown
Message-ID: <20150527102334.GD11677@x1>
References: <1432446213-4886-1-git-send-email-k.kozlowski.k@gmail.com>
 <1432446213-4886-3-git-send-email-k.kozlowski.k@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1432446213-4886-3-git-send-email-k.kozlowski.k@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 24 May 2015, Krzysztof Kozlowski wrote:

> Store the device type (obtained from i2c_device_id) as an enum and add a
> default type of unknown to distinguish from case when this is not set
> at all.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
>  include/linux/mfd/max77693-private.h | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Applied, thanks.

> diff --git a/include/linux/mfd/max77693-private.h b/include/linux/mfd/max77693-private.h
> index ad67b8235a8d..e3c0afff38d3 100644
> --- a/include/linux/mfd/max77693-private.h
> +++ b/include/linux/mfd/max77693-private.h
> @@ -529,13 +529,18 @@ enum max77693_irq_muic {
>  	MAX77693_MUIC_IRQ_NR,
>  };
>  
> +enum max77693_types {
> +	TYPE_MAX77693_UNKNOWN,
> +	TYPE_MAX77693,
> +};
> +
>  struct max77693_dev {
>  	struct device *dev;
>  	struct i2c_client *i2c;		/* 0xCC , PMIC, Charger, Flash LED */
>  	struct i2c_client *muic;	/* 0x4A , MUIC */
>  	struct i2c_client *haptic;	/* 0x90 , Haptic */
>  
> -	int type;
> +	enum max77693_types type;
>  
>  	struct regmap *regmap;
>  	struct regmap *regmap_muic;
> @@ -549,8 +554,4 @@ struct max77693_dev {
>  	int irq;
>  };
>  
> -enum max77693_types {
> -	TYPE_MAX77693,
> -};
> -
>  #endif /*  __LINUX_MFD_MAX77693_PRIV_H */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog