From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751935AbbE0KcR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 06:32:17 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:35632 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751307AbbE0KcQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 06:32:16 -0400
Date: Wed, 27 May 2015 11:32:10 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Hongzhou Yang <hongzhou.yang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
        Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
        Sascha Hauer <kernel@pengutronix.de>, yingjoe.chen@mediatek.com,
        eddie.huang@mediatek.com, dandan.he@mediatek.com,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.
Message-ID: <20150527103210.GI11677@x1>
References: <1432717835-16398-1-git-send-email-hongzhou.yang@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1432717835-16398-1-git-send-email-hongzhou.yang@mediatek.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 27 May 2015, Hongzhou Yang wrote:

> Base on Lee Jones' comment, change pinctrl subnode name.
> 
> ---
> Register pinctrl subnode into 6397 mfd cell.

Sascha already mentioned what's wrong here, so I'll not labour the
point.

I'm feeling generous, I'll apply this and make the necessary changes
myself.  Please bear the points in mind for next time however.

Applied, thanks.

> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/mt6397-core.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..e50a9bc 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog