[PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

[PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

[Hongzhou Yang]

Base on Lee Jones' comment, change pinctrl subnode name.

---
Register pinctrl subnode into 6397 mfd cell.

Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mfd/mt6397-core.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 09bc780..e50a9bc 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
 	}, {
 		.name = "mt6397-clk",
 		.of_compatible = "mediatek,mt6397-clk",
+	}, {
+		.name = "mt6397-pinctrl",
+		.of_compatible = "mediatek,mt6397-pinctrl",
 	},
 };
 
-- 
1.7.9.5

Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

[Sascha Hauer]

The subject lacks the mt6397 keyword. In the subject you say this is
about GPIO, but the patch seems to be about pinctrl.

On Wed, May 27, 2015 at 02:10:35AM -0700, Hongzhou Yang wrote:
> Base on Lee Jones' comment, change pinctrl subnode name.

This is the changelog, should be below the three --- so that git am
doesn't add this to the commit message

> 
> ---
> Register pinctrl subnode into 6397 mfd cell.

This is the commit message, should be above the three ---

> 
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/mt6397-core.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..e50a9bc 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };
>  

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

[Lee Jones]

On Wed, 27 May 2015, Hongzhou Yang wrote:

> Base on Lee Jones' comment, change pinctrl subnode name.
> 
> ---
> Register pinctrl subnode into 6397 mfd cell.

Sascha already mentioned what's wrong here, so I'll not labour the
point.

I'm feeling generous, I'll apply this and make the necessary changes
myself.  Please bear the points in mind for next time however.

Applied, thanks.

> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/mt6397-core.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..e50a9bc 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

[Hongzhou Yang]

On Wed, 2015-05-27 at 11:32 +0100, Lee Jones wrote:
> On Wed, 27 May 2015, Hongzhou Yang wrote:
> 
> > Base on Lee Jones' comment, change pinctrl subnode name.
> > 
> > ---
> > Register pinctrl subnode into 6397 mfd cell.
> 
> Sascha already mentioned what's wrong here, so I'll not labour the
> point.
> 
> I'm feeling generous, I'll apply this and make the necessary changes
> myself.  Please bear the points in mind for next time however.
> 
> Applied, thanks.
> 

Ok, I will pay more attention to it next time.
Thank you very much.

Yours,
Hongzhou