From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbbE0MHN (ORCPT ); Wed, 27 May 2015 08:07:13 -0400 Received: from mail-am1on0119.outbound.protection.outlook.com ([157.56.112.119]:53026 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751307AbbE0MHK (ORCPT ); Wed, 27 May 2015 08:07:10 -0400 From: "Harisangam, Sharvari (S.)" To: Sudip Mukherjee CC: "forest@alittletooquiet.net" , "gregkh@linuxfoundation.org" , "tvboxspy@gmail.com" , "gclement@baobob.org" , "haticeerturk27@gmail.com" , "mahfouz.saif.elyazal@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable Thread-Topic: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable Thread-Index: AQHQluV147JUjy9uAkmcldnntxOMep2NtYGAgAIH8IA= Date: Wed, 27 May 2015 12:07:06 +0000 Message-ID: <20150527120653.GA16002@ubuntu> References: <20150525122207.GA13676@ubuntu> <20150526050557.GD3465@sudip-PC> In-Reply-To: <20150526050557.GD3465@sudip-PC> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sharisan@visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.0.77.198] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1350; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DB5PR06MB1350;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1350; x-forefront-prvs: 05891FB07F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(51704005)(24454002)(199003)(68736005)(5001830100001)(92566002)(46102003)(106356001)(33716001)(189998001)(62966003)(4001540100001)(106116001)(97736004)(40100003)(122556002)(77156002)(5001960100002)(5002640100001)(5001860100001)(110136002)(2950100001)(2860100001)(87936001)(2656002)(86362001)(50986999)(101416001)(19580395003)(19580405001)(99936001)(76176999)(54356999)(33656002)(66066001)(102836002)(105586002)(81156007)(2900100001)(64706001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1350;H:DB5PR06MB1352.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: multipart/mixed; boundary="_002_20150527120653GA16002ubuntu_" MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2015 12:07:06.5186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1350 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --_002_20150527120653GA16002ubuntu_ Content-Type: text/plain; charset="us-ascii" Content-ID: <48F4D3986200C448BED828C28799D094@eurprd06.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote: > On Mon, May 25, 2015 at 12:22:25PM +0000, Harisangam, Sharvari (S.) wrote= : > > Modified the if-else statements to remove unnecessary comparisons. > > This change was detected with the help of coccinelle tool > >=20 > > Signed-off-by: Harisangam Sharvari S > you should not use initials in the Signed-off-by name. This should be > the name which you usually use to sign any legal document. >=20 > regards > sudip The signed off name is now changed . -Sharvari Harisangam --_002_20150527120653GA16002ubuntu_ Content-Type: text/x-diff; name="0001-Staging-vt6655-Remove-unnecessary-equality-checks-fo.patch" Content-Description: 0001-Staging-vt6655-Remove-unnecessary-equality-checks-fo.patch Content-Disposition: attachment; filename="0001-Staging-vt6655-Remove-unnecessary-equality-checks-fo.patch"; size=2716; creation-date="Wed, 27 May 2015 12:07:06 GMT"; modification-date="Wed, 27 May 2015 12:07:06 GMT" Content-ID: <00AFC2DDFDF95148944F1944A15F3C8D@eurprd06.prod.outlook.com> Content-Transfer-Encoding: base64 RnJvbSA4MjIwNDVjNGQzYzI4ZDM2YjhhNTQwNTIwYTQ4Nzk1ZmVjNGM3ZWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogSGFyaXNhbmdhbSBTaGFydmFyaSA8c2hhcmlzYW5AdmlzdGVv bi5jb20+DQpEYXRlOiBNb24sIDI1IE1heSAyMDE1IDE1OjQyOjQzICswNTMwDQpTdWJqZWN0OiBb UEFUQ0hdIFN0YWdpbmc6IHZ0NjY1NTogUmVtb3ZlIHVubmVjZXNzYXJ5IGVxdWFsaXR5IGNoZWNr cyBmb3IgYQ0KIGJvb2wgdmFyaWFibGUNCg0KTW9kaWZpZWQgdGhlIGlmLWVsc2Ugc3RhdGVtZW50 cyB0byByZW1vdmUgdW5uZWNlc3NhcnkgY29tcGFyaXNvbnMuDQpUaGlzIGNoYW5nZSB3YXMgZGV0 ZWN0ZWQgd2l0aCB0aGUgaGVscCBvZiBjb2NjaW5lbGxlIHRvb2wNCg0KU2lnbmVkLW9mZi1ieTog SGFyaXNhbmdhbSBTaGFydmFyaSA8c2hhcmlzYW5AdmlzdGVvbi5jb20+DQotLS0NCiBkcml2ZXJz L3N0YWdpbmcvdnQ2NjU1L3J4dHguYyB8ICAgIDggKysrKy0tLS0NCiAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9z dGFnaW5nL3Z0NjY1NS9yeHR4LmMgYi9kcml2ZXJzL3N0YWdpbmcvdnQ2NjU1L3J4dHguYw0KaW5k ZXggNzQ2ODc3Ni4uN2ZlZGRlMyAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvc3RhZ2luZy92dDY2NTUv cnh0eC5jDQorKysgYi9kcml2ZXJzL3N0YWdpbmcvdnQ2NjU1L3J4dHguYw0KQEAgLTEwOTMsNyAr MTA5Myw3IEBAIHNfY2JGaWxsVHhCdWZIZWFkKHN0cnVjdCB2bnRfcHJpdmF0ZSAqcERldmljZSwg dW5zaWduZWQgY2hhciBieVBrdFR5cGUsDQogCWlmIChieVBrdFR5cGUgPT0gUEtfVFlQRV8xMUdC IHx8IGJ5UGt0VHlwZSA9PSBQS19UWVBFXzExR0EpIHsvKiA4MDIuMTFnIHBhY2tldCAqLw0KIA0K IAkJaWYgKGJ5RkJPcHRpb24gPT0gQVVUT19GQl9OT05FKSB7DQotCQkJaWYgKGJSVFMgPT0gdHJ1 ZSkgey8qIFJUU19uZWVkICovDQorCQkJaWYgKGJSVFMpIHsvKiBSVFNfbmVlZCAqLw0KIAkJCQlw dlJydlRpbWUgPSAodm9pZCAqKShwYnlUeEJ1ZmZlckFkZHIgKyB3VHhCdWZTaXplKTsNCiAJCQkJ cE1JQ0hEUiA9IChzdHJ1Y3Qgdm50X21pY19oZHIgKikocGJ5VHhCdWZmZXJBZGRyICsgd1R4QnVm U2l6ZSArIHNpemVvZihzdHJ1Y3Qgdm50X3Jydl90aW1lX3J0cykpOw0KIAkJCQlwdlJUUyA9ICh2 b2lkICopKHBieVR4QnVmZmVyQWRkciArIHdUeEJ1ZlNpemUgKyBzaXplb2Yoc3RydWN0IHZudF9y cnZfdGltZV9ydHMpICsgY2JNSUNIRFIpOw0KQEAgLTExMTUsNyArMTExNSw3IEBAIHNfY2JGaWxs VHhCdWZIZWFkKHN0cnVjdCB2bnRfcHJpdmF0ZSAqcERldmljZSwgdW5zaWduZWQgY2hhciBieVBr dFR5cGUsDQogCQkJfQ0KIAkJfSBlbHNlIHsNCiAJCQkvKiBBdXRvIEZhbGwgQmFjayAqLw0KLQkJ CWlmIChiUlRTID09IHRydWUpIHsvKiBSVFNfbmVlZCAqLw0KKwkJCWlmIChiUlRTKSB7LyogUlRT X25lZWQgKi8NCiAJCQkJcHZScnZUaW1lID0gKHZvaWQgKikocGJ5VHhCdWZmZXJBZGRyICsgd1R4 QnVmU2l6ZSk7DQogCQkJCXBNSUNIRFIgPSAoc3RydWN0IHZudF9taWNfaGRyICopIChwYnlUeEJ1 ZmZlckFkZHIgKyB3VHhCdWZTaXplICsgc2l6ZW9mKHN0cnVjdCB2bnRfcnJ2X3RpbWVfcnRzKSk7 DQogCQkJCXB2UlRTID0gKHZvaWQgKikgKHBieVR4QnVmZmVyQWRkciArIHdUeEJ1ZlNpemUgKyBz aXplb2Yoc3RydWN0IHZudF9ycnZfdGltZV9ydHMpICsgY2JNSUNIRFIpOw0KQEAgLTExMzgsNyAr MTEzOCw3IEBAIHNfY2JGaWxsVHhCdWZIZWFkKHN0cnVjdCB2bnRfcHJpdmF0ZSAqcERldmljZSwg dW5zaWduZWQgY2hhciBieVBrdFR5cGUsDQogCX0gZWxzZSB7LyogODAyLjExYS9iIHBhY2tldCAq Lw0KIA0KIAkJaWYgKGJ5RkJPcHRpb24gPT0gQVVUT19GQl9OT05FKSB7DQotCQkJaWYgKGJSVFMg PT0gdHJ1ZSkgew0KKwkJCWlmIChiUlRTKSB7DQogCQkJCXB2UnJ2VGltZSA9ICh2b2lkICopKHBi eVR4QnVmZmVyQWRkciArIHdUeEJ1ZlNpemUpOw0KIAkJCQlwTUlDSERSID0gKHN0cnVjdCB2bnRf bWljX2hkciAqKSAocGJ5VHhCdWZmZXJBZGRyICsgd1R4QnVmU2l6ZSArIHNpemVvZihzdHJ1Y3Qg dm50X3Jydl90aW1lX2FiKSk7DQogCQkJCXB2UlRTID0gKHZvaWQgKikocGJ5VHhCdWZmZXJBZGRy ICsgd1R4QnVmU2l6ZSArIHNpemVvZihzdHJ1Y3Qgdm50X3Jydl90aW1lX2FiKSArIGNiTUlDSERS KTsNCkBAIC0xMTU4LDcgKzExNTgsNyBAQCBzX2NiRmlsbFR4QnVmSGVhZChzdHJ1Y3Qgdm50X3By aXZhdGUgKnBEZXZpY2UsIHVuc2lnbmVkIGNoYXIgYnlQa3RUeXBlLA0KIAkJCX0NCiAJCX0gZWxz ZSB7DQogCQkJLyogQXV0byBGYWxsIEJhY2sgKi8NCi0JCQlpZiAoYlJUUyA9PSB0cnVlKSB7IC8q IFJUU19uZWVkICovDQorCQkJaWYgKGJSVFMpIHsgLyogUlRTX25lZWQgKi8NCiAJCQkJcHZScnZU aW1lID0gKHZvaWQgKikocGJ5VHhCdWZmZXJBZGRyICsgd1R4QnVmU2l6ZSk7DQogCQkJCXBNSUNI RFIgPSAoc3RydWN0IHZudF9taWNfaGRyICopIChwYnlUeEJ1ZmZlckFkZHIgKyB3VHhCdWZTaXpl ICsgc2l6ZW9mKHN0cnVjdCB2bnRfcnJ2X3RpbWVfYWIpKTsNCiAJCQkJcHZSVFMgPSAodm9pZCAq KShwYnlUeEJ1ZmZlckFkZHIgKyB3VHhCdWZTaXplICsgc2l6ZW9mKHN0cnVjdCB2bnRfcnJ2X3Rp bWVfYWIpICsgY2JNSUNIRFIpOw0KLS0gDQoxLjcuOS41DQoNCg== --_002_20150527120653GA16002ubuntu_--