From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbbE0MY1 (ORCPT ); Wed, 27 May 2015 08:24:27 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36215 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbbE0MYY (ORCPT ); Wed, 27 May 2015 08:24:24 -0400 Date: Wed, 27 May 2015 13:24:18 +0100 From: Lee Jones To: Krzysztof =?utf-8?Q?Koz=C5=82owski?= Cc: Chanwoo Choi , MyungJoo Ham , Dmitry Torokhov , Samuel Ortiz , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 2/9] mfd: max77693: Store I2C device type as enum and add default unknown Message-ID: <20150527122418.GM11677@x1> References: <1432446213-4886-1-git-send-email-k.kozlowski.k@gmail.com> <1432446213-4886-3-git-send-email-k.kozlowski.k@gmail.com> <20150527102334.GD11677@x1> <20150527121536.GK11677@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150527121536.GK11677@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 May 2015, Lee Jones wrote: > On Wed, 27 May 2015, Krzysztof Kozłowski wrote: > > > 2015-05-27 19:23 GMT+09:00 Lee Jones : > > > On Sun, 24 May 2015, Krzysztof Kozlowski wrote: > > > > > >> Store the device type (obtained from i2c_device_id) as an enum and add a > > >> default type of unknown to distinguish from case when this is not set > > >> at all. > > >> > > >> Signed-off-by: Krzysztof Kozlowski > > >> --- > > >> include/linux/mfd/max77693-private.h | 11 ++++++----- > > >> 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > Applied, thanks. > > > > Thanks. > > > > I was thinking about merging everything through one tree because of > > the dependency (successive patches depend on previous) but I don't > > mind choosing different strategy. However if you picked this one maybe > > you can also apply the patch 1/9: > > mfd/extcon: max77693: Remove unused extern declarations and max77693_dev members > > > > It already got ack from Chanwoo. > > > > Other patches depend on these so either everything will go through > > your tree or you will prepare an immutable branch for e.g. Mark (as > > everything is around regulator drivers). > > > > Anyway I need some input from Mark about the patches 4, 5 and 9. Rest > > of them already have his ack. > > I'm happy to do that. Just let me know when you have all the Acks you > need and I'll apply them all at once. In fact, it's probably better to withdraw this patch too, then apply it with all the others. Patch unapplied (but you can add my Ack). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog