From: Borislav Petkov <bp@suse.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rustad <mark.d.rustad@intel.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible
Date: Wed, 27 May 2015 14:51:36 +0200 [thread overview]
Message-ID: <20150527125136.GE19582@pd.tnic> (raw)
In-Reply-To: <CANCZXo7mByhuh9h49gzSRX-vBBscxgarMmNh1Q=yStXziqNocQ@mail.gmail.com>
On Wed, May 27, 2015 at 06:12:59PM +0600, Alexander Kuleshov wrote:
> Is it bad or we no need in it? I want to understand not only how
> kernel works, but also why it written so and I can't understand why we
> have 'earlyprintk' (or another feature) in one place and do not have
> in another.
So how hard was it to say that the first time?
That you want to be able to dump interesting parts of the early boot
process and you would like the early console working as early as
possible?
This is what I wanted to know - what is your use case. Not what is there
and what isn't there in the code. That I can figure out by browsing the
code myself. Most of the time, at least. :-)
Now, have you tested this on real hardware? Because your 0/n message
said "qemu" but I don't think that's sufficient. If we're going to
enable early_printk this early, we'd need it working on real hardware
too.
For that I'd suggest adding a 4th, test patch which issues a couple of
numbered early_printk() lines which we could run on a bunch of machines
to see whether it actually works.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-05-27 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:06 [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible Alexander Kuleshov
2015-05-26 13:07 ` [PATCH v8 1/3] x86/setup: introduce setup_bultin_cmdline Alexander Kuleshov
2015-05-26 13:07 ` [PATCH v8 2/3] x86/setup: handle builtin command line as early as possible Alexander Kuleshov
2015-05-26 13:08 ` [PATCH v8 3/3] x86/earlyprintk: setup earlyprintk " Alexander Kuleshov
2015-05-26 13:17 ` [PATCH v8 0/3] x86/earlyprintk: setup serial " Borislav Petkov
2015-05-26 13:20 ` Alexander Kuleshov
2015-05-26 13:57 ` Borislav Petkov
2015-05-26 14:11 ` Alexander Kuleshov
2015-05-26 14:58 ` Andy Shevchenko
2015-05-26 21:34 ` Borislav Petkov
2015-05-27 7:33 ` Alexander Kuleshov
2015-05-27 12:01 ` Borislav Petkov
2015-05-27 12:12 ` Alexander Kuleshov
2015-05-27 12:51 ` Borislav Petkov [this message]
2015-05-28 8:01 ` Alexander Kuleshov
2015-05-29 16:55 ` Borislav Petkov
2015-06-02 11:25 ` Alexander Kuleshov
-- strict thread matches above, loose matches on Subject: below --
2015-05-18 9:19 [PATCH v7 " Alexander Kuleshov
2015-05-26 13:04 ` [PATCH v8 " Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527125136.GE19582@pd.tnic \
--to=bp@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox