From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbbE0NAn (ORCPT ); Wed, 27 May 2015 09:00:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:41419 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbbE0NAi (ORCPT ); Wed, 27 May 2015 09:00:38 -0400 Date: Wed, 27 May 2015 10:00:33 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v4 01/29] tools: Add __aligned_u64 to types.h Message-ID: <20150527130033.GS17970@kernel.org> References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432704004-171454-2-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 27, 2015 at 05:19:36AM +0000, Wang Nan escreveu: > Following patches will introduce linux/bpf.h to a new libbpf library, > which requires definition of __aligned_u64. This patch add it to the > common types.h for tools. This was already merged, see: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/tools?h=perf/core More specifically: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/tools?h=perf/core&id=70ba6b8f975bcff56e180e2c7550d2302fcbf923 So you can drop it from your patchset. BTW, where are you basing your work? If you do it over tip/perf/core you may find some of the trivial stuff being added there, like this one. - Arnaldo > Signed-off-by: Wang Nan > --- > tools/include/linux/types.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/include/linux/types.h b/tools/include/linux/types.h > index b5cf25e..10a2cdc 100644 > --- a/tools/include/linux/types.h > +++ b/tools/include/linux/types.h > @@ -60,6 +60,11 @@ typedef __u32 __bitwise __be32; > typedef __u64 __bitwise __le64; > typedef __u64 __bitwise __be64; > > +/* Taken from uapi/linux/types.h. Required by linux/bpf.h */ > +#ifndef __aligned_u64 > +# define __aligned_u64 __u64 __attribute__((aligned(8))) > +#endif > + > struct list_head { > struct list_head *next, *prev; > }; > -- > 1.8.3.4