From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbbE0NVP (ORCPT ); Wed, 27 May 2015 09:21:15 -0400 Received: from mail.kernel.org ([198.145.29.136]:42366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbbE0NVO (ORCPT ); Wed, 27 May 2015 09:21:14 -0400 Date: Wed, 27 May 2015 10:21:09 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v4 03/29] perf tools: Move linux/{list.h,poison.h} to tools/include Message-ID: <20150527132109.GV17970@kernel.org> References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-4-git-send-email-wangnan0@huawei.com> <20150527131512.GU17970@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150527131512.GU17970@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 27, 2015 at 10:15:12AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, May 27, 2015 at 05:19:38AM +0000, Wang Nan escreveu: > > This patch moves list.h from tools/perf/util/include/linux/list.h > > to tools/include/linux/list.h to enable other libraries use macros in > I'll apply this, but when doing these moves, one has to worry that these > build targets continue working: > [acme@ssdandy linux]$ make help | grep perf > perf-tar-src-pkg - Build perf-4.1.0-rc2.tar source tarball > perf-targz-src-pkg - Build perf-4.1.0-rc2.tar.gz source tarball > This, BTW, would have been caught if you had run: > > make -C tools/perf build-test > > One of the last tests will do this packaging and building, alerting you that > something is missing. > > I am doing this for the two patches in this series that moves things to tools, So, to summarize this further, and to run just this 'tarpkg' test, to speed up testing for this specific case: [acme@ssdandy linux]$ vim tools/perf/MANIFEST [acme@ssdandy linux]$ make -C tools/perf -f tests/make tarpkg make: Entering directory `/home/acme/git/linux/tools/perf' - tarpkg: ./tests/perf-targz-src-pkg . make: Leaving directory `/home/acme/git/linux/tools/perf' [acme@ssdandy linux]$ echo $? 0 [acme@ssdandy linux]$ git diff diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST index a83cf75164e1..fce4a47347aa 100644 --- a/tools/perf/MANIFEST +++ b/tools/perf/MANIFEST @@ -40,6 +40,7 @@ tools/include/linux/bitops.h tools/include/linux/compiler.h tools/include/linux/export.h tools/include/linux/hash.h +tools/include/linux/kernel.h tools/include/linux/log2.h tools/include/linux/types.h include/asm-generic/bitops/arch_hweight.h [acme@ssdandy linux]$ git commit -a --amend - Arnaldo