From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Marcin Jabrzyk <m.jabrzyk@samsung.com>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv2] zram: check comp algorithm availability earlier
Date: Wed, 27 May 2015 22:32:19 +0900 [thread overview]
Message-ID: <20150527133219.GF11609@blaptop> (raw)
In-Reply-To: <1432725612-1068-1-git-send-email-sergey.senozhatsky@gmail.com>
On Wed, May 27, 2015 at 08:20:12PM +0900, Sergey Senozhatsky wrote:
> Improvement idea by Marcin Jabrzyk.
>
> comp_algorithm_store() silently accepts any supplied algorithm
> name, because zram performs algorithm availability check later,
> during the device configuration phase in disksize_store() and
> emits the following error:
> "zram: Cannot initialise %s compressing backend"
>
> this error line is somewhat generic and, besides, can indicate
> a failed attempt to allocate compression backend's working
> buffers.
>
> add algorithm availability check to comp_algorithm_store():
>
> echo lzz > /sys/block/zram0/comp_algorithm
> -bash: echo: write error: Invalid argument
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Marcin Jabrzyk <m.jabrzyk@samsung.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
--
Kind regards,
Minchan Kim
prev parent reply other threads:[~2015-05-27 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 11:20 [PATCHv2] zram: check comp algorithm availability earlier Sergey Senozhatsky
2015-05-27 13:32 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527133219.GF11609@blaptop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.jabrzyk@samsung.com \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox