From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbbE0Pa3 (ORCPT ); Wed, 27 May 2015 11:30:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:51268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbbE0Pa2 (ORCPT ); Wed, 27 May 2015 11:30:28 -0400 Date: Wed, 27 May 2015 12:30:24 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v4 03/29] perf tools: Move linux/{list.h,poison.h} to tools/include Message-ID: <20150527153024.GA24859@kernel.org> References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-4-git-send-email-wangnan0@huawei.com> <20150527131512.GU17970@kernel.org> <20150527132109.GV17970@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150527132109.GV17970@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 27, 2015 at 10:21:09AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, May 27, 2015 at 10:15:12AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, May 27, 2015 at 05:19:38AM +0000, Wang Nan escreveu: > > > This patch moves list.h from tools/perf/util/include/linux/list.h > > > to tools/include/linux/list.h to enable other libraries use macros in > > > I'll apply this, but when doing these moves, one has to worry that these > > build targets continue working: > > > [acme@ssdandy linux]$ make help | grep perf > > perf-tar-src-pkg - Build perf-4.1.0-rc2.tar source tarball > > perf-targz-src-pkg - Build perf-4.1.0-rc2.tar.gz source tarball > > > > > This, BTW, would have been caught if you had run: > > > > make -C tools/perf build-test > > > > One of the last tests will do this packaging and building, alerting you that > > something is missing. > > > > I am doing this for the two patches in this series that moves things to tools, > > So, to summarize this further, and to run just this 'tarpkg' test, to speed up > testing for this specific case: And it explodes on RHEL6.6, I'll have to test this further... MKDIR /tmp/build/perf/util/ CC /tmp/build/perf/util/values.o In file included from /home/acme/git/linux/include/uapi/linux/kernel.h:4, from util/util.h:73, from util/values.c:3: /home/acme/git/linux/include/uapi/linux/sysinfo.h:8: error: expected specifier-qualifier-list before ‘__kernel_long_t’ cc1: warnings being treated as errors In file included from util/values.c:3: util/util.h: In function ‘path__join’: util/util.h:306: error: implicit declaration of function ‘scnprintf’ util/util.h:306: error: nested extern declaration of ‘scnprintf’ make[3]: *** [/tmp/build/perf/util/values.o] Error 1 make[2]: *** [util] Error 2 make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2 make[1]: *** Waiting for unfinished jobs.... PERF_VERSION = 4.1.rc2.ga82d24e make: *** [install-bin] Error 2 make: Leaving directory `/home/acme/git/linux/tools/perf' [acme@sandy linux]$ - Arnaldo