From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752084AbbE0Sx4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 14:53:56 -0400
Received: from down.free-electrons.com ([37.187.137.238]:41770 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751319AbbE0Sxy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 14:53:54 -0400
Date: Wed, 27 May 2015 20:53:52 +0200
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com,
        linux-kernel@vger.kernel.org, Vincent Donnefort <vdonnefort@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>, oen@telliq.com
Subject: Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an
 invalid time.
Message-ID: <20150527185352.GJ2185@piout.net>
References: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
>  		pcf8563->voltage_low = 1;
>  		dev_info(&client->dev,

Aren't dev_err or dev_warn more appropriate? You used dev_err in your
first patch, what made you change your mind?

>  			"low voltage detected, date/time is not reliable.\n");
> +		return -EINVAL;
>  	}
>  
>  	dev_dbg(&client->dev,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com