From: Stephen Boyd <sboyd@codeaurora.org>
To: Ankit Gupta <ankgupta@codeaurora.org>
Cc: gavidov@codeaurora.org, sdharia@codeaurora.org,
ivan.ivanov@linaro.org, svarbanov@mm-sol.com,
rostedt@goodmis.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, collinsd@codeaurora.org,
osvaldob@codeaurora.org, linux-kernel@vger.kernel.org,
mlocke@codeaurora.org, galak@codeaurora.org,
agross@codeaurora.org
Subject: Re: [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver
Date: Wed, 27 May 2015 13:06:29 -0700 [thread overview]
Message-ID: <20150527200629.GB24204@codeaurora.org> (raw)
In-Reply-To: <4da368f6f34fc07eff97ddc3dfbced2c.squirrel@www.codeaurora.org>
On 05/27, Ankit Gupta wrote:
> >
> > How is this any better than irq tracepoints that we already have for
> > generic irqs?
> >
> It is better than generic irq tracepoints because it provides bus specific
> information (sid and address(pid) of slave write), driver specific
> information (apid (pmic-peripheral) and func_num) and statistics (apid
> range).
> Recall that *slave* read/write cannot be traced by the spmi framework ftrace.
>
Don't we already get all this information based on how we map
interrupts to devices in DT? It feels to me that the same
argument here could be applied to all the random gpio expanders
and chained interrupt controllers that we support in the kernel.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-27 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:39 [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver Ankit Gupta
2015-05-26 23:44 ` Stephen Boyd
2015-05-27 15:06 ` Ankit Gupta
2015-05-27 20:06 ` Stephen Boyd [this message]
2015-05-28 23:02 ` Gilad Avidov
2015-05-29 1:15 ` Stephen Boyd
2015-05-29 19:56 ` Gilad Avidov
2015-05-26 23:58 ` Steven Rostedt
2015-05-27 15:09 ` Ankit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527200629.GB24204@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=ankgupta@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=osvaldob@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=sdharia@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox