From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315AbbE0UGd (ORCPT ); Wed, 27 May 2015 16:06:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52877 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbbE0UGb (ORCPT ); Wed, 27 May 2015 16:06:31 -0400 Date: Wed, 27 May 2015 13:06:29 -0700 From: Stephen Boyd To: Ankit Gupta Cc: gavidov@codeaurora.org, sdharia@codeaurora.org, ivan.ivanov@linaro.org, svarbanov@mm-sol.com, rostedt@goodmis.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, collinsd@codeaurora.org, osvaldob@codeaurora.org, linux-kernel@vger.kernel.org, mlocke@codeaurora.org, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver Message-ID: <20150527200629.GB24204@codeaurora.org> References: <1432683555-4644-1-git-send-email-ankgupta@codeaurora.org> <5565056D.4050200@codeaurora.org> <4da368f6f34fc07eff97ddc3dfbced2c.squirrel@www.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4da368f6f34fc07eff97ddc3dfbced2c.squirrel@www.codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27, Ankit Gupta wrote: > > > > How is this any better than irq tracepoints that we already have for > > generic irqs? > > > It is better than generic irq tracepoints because it provides bus specific > information (sid and address(pid) of slave write), driver specific > information (apid (pmic-peripheral) and func_num) and statistics (apid > range). > Recall that *slave* read/write cannot be traced by the spmi framework ftrace. > Don't we already get all this information based on how we map interrupts to devices in DT? It feels to me that the same argument here could be applied to all the random gpio expanders and chained interrupt controllers that we support in the kernel. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project