From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Paul Turner <pjt@google.com>,
Benjamin Segall <bsegall@google.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
arjan.van.de.ven@intel.com, Len Brown <len.brown@intel.com>,
rafael.j.wysocki@intel.com,
"fengguang.wu@intel.com" <fengguang.wu@intel.com>
Subject: Re: [PATCH v8 2/4] sched: Rewrite runnable load and utilization average tracking
Date: Thu, 28 May 2015 06:36:16 +0800 [thread overview]
Message-ID: <20150527223615.GA522@intel.com> (raw)
In-Reply-To: <CAKfTPtDfHKuUYLkrmoMP2-LUz__qpNw7=QOymzUucJtUyWu=2A@mail.gmail.com>
On Tue, May 26, 2015 at 06:06:23PM +0200, Vincent Guittot wrote:
> > + sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);
>
> Brackets are missing around u64 to cast util_sum
>
My appology for this, and thank you, Vincent.
Sending the below patch here instead of sending the series.
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2dd201e..a8fd7b9 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2584,7 +2584,7 @@ static __always_inline int __update_load_avg(u64 now, int cpu,
delta %= 1024;
sa->load_sum = decay_load(sa->load_sum, periods + 1);
- sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);
+ sa->util_sum = decay_load((u64)(sa->util_sum), periods + 1);
/* Efficiently calculate \sum (1..n_period) 1024*y^i */
contrib = __compute_runnable_contrib(periods);
next prev parent reply other threads:[~2015-05-28 6:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1432518587-114210-1-git-send-email-yuyang.du@intel.com>
[not found] ` <1432518587-114210-3-git-send-email-yuyang.du@intel.com>
2015-05-26 16:06 ` [PATCH v8 2/4] sched: Rewrite runnable load and utilization average tracking Vincent Guittot
2015-05-27 22:36 ` Yuyang Du [this message]
2015-06-02 0:25 ` [PATCH v8 0/4] " Yuyang Du
2015-06-09 1:21 ` Yuyang Du
2015-06-15 10:38 ` Boqun Feng
2015-06-15 18:46 ` Yuyang Du
2015-06-15 19:26 [Resend PATCH " Yuyang Du
2015-06-15 19:26 ` [PATCH v8 2/4] " Yuyang Du
2015-06-19 6:00 ` Boqun Feng
2015-06-18 23:05 ` Yuyang Du
2015-06-19 7:57 ` Boqun Feng
2015-06-19 3:11 ` Yuyang Du
2015-06-19 12:22 ` Boqun Feng
2015-06-21 22:43 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527223615.GA522@intel.com \
--to=yuyang.du@intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fengguang.wu@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).