From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752631AbbE1G3X (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 May 2015 02:29:23 -0400
Received: from mga11.intel.com ([192.55.52.93]:3475 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751264AbbE1G3P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 May 2015 02:29:15 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,511,1427785200"; 
   d="scan'208";a="701408535"
Date: Thu, 28 May 2015 06:36:16 +0800
From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Paul Turner <pjt@google.com>, Benjamin Segall <bsegall@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        arjan.van.de.ven@intel.com, Len Brown <len.brown@intel.com>,
        rafael.j.wysocki@intel.com,
        "fengguang.wu@intel.com" <fengguang.wu@intel.com>
Subject: Re: [PATCH v8 2/4] sched: Rewrite runnable load and utilization
 average tracking
Message-ID: <20150527223615.GA522@intel.com>
References: <1432518587-114210-1-git-send-email-yuyang.du@intel.com>
 <1432518587-114210-3-git-send-email-yuyang.du@intel.com>
 <CAKfTPtDfHKuUYLkrmoMP2-LUz__qpNw7=QOymzUucJtUyWu=2A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtDfHKuUYLkrmoMP2-LUz__qpNw7=QOymzUucJtUyWu=2A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 26, 2015 at 06:06:23PM +0200, Vincent Guittot wrote:
> > +               sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);
> 
> Brackets are missing around u64 to cast util_sum
> 

My appology for this, and thank you, Vincent.

Sending the below patch here instead of sending the series.

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2dd201e..a8fd7b9 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2584,7 +2584,7 @@ static __always_inline int __update_load_avg(u64 now, int cpu,
 		delta %= 1024;
 
 		sa->load_sum = decay_load(sa->load_sum, periods + 1);
-		sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);
+		sa->util_sum = decay_load((u64)(sa->util_sum), periods + 1);
 
 		/* Efficiently calculate \sum (1..n_period) 1024*y^i */
 		contrib = __compute_runnable_contrib(periods);