From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbbE1B5Y (ORCPT ); Wed, 27 May 2015 21:57:24 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33193 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbE1B5P (ORCPT ); Wed, 27 May 2015 21:57:15 -0400 Date: Wed, 27 May 2015 18:57:13 -0700 From: Alexei Starovoitov To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v4 16/29] bpf tools: Create eBPF maps defined in an object file Message-ID: <20150528015713.GG20764@Alexeis-MacBook-Pro.local> References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-17-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432704004-171454-17-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 05:19:51AM +0000, Wang Nan wrote: > This patch creates maps based on 'map' section in object file using > bpf_create_map(), and store the fds into an array in > 'struct bpf_object'. Since the byte order of the object may differ > from the host, swap map definition before processing. obsolete commit log? The code doesn't do byteswap and it shouldn't. The other patch already checked for matching endiannes. > This is the first patch in 'loading' phase. Previous patches parse ELF > object file and create needed data structure, but doesn't play with > kernel. They belong to 'opening' phase. > > Signed-off-by: Wang Nan