From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbbE1HGn (ORCPT ); Thu, 28 May 2015 03:06:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35040 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbbE1HGe (ORCPT ); Thu, 28 May 2015 03:06:34 -0400 Date: Thu, 28 May 2015 10:06:13 +0300 From: Dan Carpenter To: "K. Y. Srinivasan" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues Message-ID: <20150528070613.GV11588@mwanda> References: <1432682469-15033-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432682469-15033-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since you're redoing this anyway. On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote: > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h > index ddcc7f8..dd45440 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -161,6 +161,7 @@ struct netvsc_device_info { > unsigned char mac_adr[ETH_ALEN]; > bool link_state; /* 0 - link up, 1 - link down */ > int ring_size; > + u32 max_num_vrss_chns; We (Joe and I) have commented before that long names don't mix well with the 80 character limit. You could just leave the "num_" out. Almost all variables are numbers in C so it doesn't add anything. regards, dan carpenter