From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751729AbbE1HPB (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 May 2015 03:15:01 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:40367 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751372AbbE1HO4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 May 2015 03:14:56 -0400
Date: Thu, 28 May 2015 10:14:44 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Laurent Navet <laurent.navet@gmail.com>, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, Julia Lawall <julia.lawall@lip6.fr>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test
Message-ID: <20150528071444.GW11588@mwanda>
References: <1432758345-8095-1-git-send-email-laurent.navet@gmail.com>
 <1432758608.2846.169.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432758608.2846.169.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> On Wed, 2015-05-27 at 22:25 +0200, Laurent Navet wrote:
> > The same code is executed regardless ret value, so this test can be
> > removed.
> []
> > diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c
> []
> > @@ -255,8 +255,6 @@ static int em_wait_ack(struct usb_device *usbdev, int send_zlp)
> >  
> >  	/*Wait for ACK*/
> >  	ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
> > -	if (ret < 0)
> > -		goto out;
> >  out:
> >  	return ret;
> >  }
> 
> Perhaps all of the uses like:
> 
> 	goto <foo>;
> <foo>:
> 
> could be modified.  There are ~150 in the kernel.

Joe, these are a kind of style.  You're just directing a newbie into a
hornets nest.  Laurant, don't do listen to Joe unless you like getting
flamed.

regards,
dan carpenter