From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753161AbbE1HVB (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 May 2015 03:21:01 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:35768 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751687AbbE1HUx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 May 2015 03:20:53 -0400
Date: Thu, 28 May 2015 10:20:39 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Laurent Navet <laurent.navet@gmail.com>, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test
Message-ID: <20150528072039.GX11588@mwanda>
References: <1432758345-8095-1-git-send-email-laurent.navet@gmail.com>
 <CAOMZO5Dnj9zeeyUQxwR5BpWDpghvNVmgRkL4BJMC9J0KXD6SKQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOMZO5Dnj9zeeyUQxwR5BpWDpghvNVmgRkL4BJMC9J0KXD6SKQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Obviously, I endorse this idea.  :)  Every out label in this file is
a do-nothing label or a do-everything label, but with bugs.  usb_boot()
should look like:

free_tx_buf:
	kfree(tx_buf);
release_firm:
	release_firmware(firm);

	ret;

If we fail to allocate "tx_buf" then we should release the firmware.
em_download_image() has the same bug as well.

regards,
dan carpenter