From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbbE1I0n (ORCPT ); Thu, 28 May 2015 04:26:43 -0400 Received: from mail-by2on0139.outbound.protection.outlook.com ([207.46.100.139]:63043 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752279AbbE1I0c (ORCPT ); Thu, 28 May 2015 04:26:32 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Thu, 28 May 2015 16:25:01 +0800 From: Dong Aisheng To: Michael Turquette CC: Dong Aisheng , , , , , , , , , Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150528082459.GA4489@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150528040919.22384.79189@quantum> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11OLC001;1:79x1a88NiNGua6RywZ5XsREBPz0rIB8tJ1xsTyWib8BEtSBldlSVWFTD8SEKk2uo6FExrE20qn2h6V7qj5nNr801UPHxJlc47VVHF8m6sSiepTvI/Bum2XI1SMuOXexfb+Du7YQEPnCVLZDsU2caVS1yV/AcIJSBFPz3rin7dcFJEQAnIt4Ipoo3kENqyyHCdUaMqIS+Ugqj2p3WtfBoZy8lik/7Exlp/roIpS6gGrbjjgZX04/5a05qmu2IzuezJ/Qga0XF2puwnXXUlWNbnOMVpBnboMW/69Zj/USOEiGaZBH0io0Z0H+zL53304RiPhoHT+0GjxYEKsB7kJ9JOw== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(979002)(6009001)(339900001)(51914003)(24454002)(199003)(51704005)(377424004)(189002)(92566002)(68736005)(4001350100001)(54356999)(76176999)(85426001)(64706001)(81156007)(4001540100001)(47776003)(50986999)(19580405001)(97736004)(83506001)(19580395003)(5001830100001)(106466001)(5001860100001)(33656002)(23726002)(2950100001)(46102003)(77096005)(110136002)(77156002)(97756001)(5001960100002)(189998001)(87936001)(6806004)(104016003)(105606002)(5001920100001)(50466002)(62966003)(46406003)(107886002)(42262002)(4001430100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB1205;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1205;2:FMlX4BYWyFz3GQoYtNtdz7nQ6EahQgDO4chAT/nSVOIRzKw1Sh9tdukKXm2eit3a;2:ZHxZEL0ZHhdwn5ir+misXLb/7/Aq3vTHH0bbOQ8DBLlIriJa8Kj5gVXUw5x5sRp8KZIau/OjbhReqHKp2o4EmGrdtAQSHVuWzl+EDAdx5t3LfZL8LZEyeRfQeeip1iZ1QAuWmhrvuKa4LOVbz6W1rkCQwKNEiFG/qH93cQYQe7c9qwCy4Uwe9DGZHb0zSvI1gHMTBlQeOmgbCUGqEIBLKJezTwL7FNRqMwAEdxKJ/Jo=;6:n98x+J2uUhrlHXm3rTn/ByltQuk5ziWntMRz1UoSvHCT15OoK9M0Qz1IcP+gZbcbSlTEftAmHvgkZStE1STUMXMMiuzMiFmWaVdk432wGiuH38YE8G47lzQaASL9xi3WxtLPrEkaqip75dS/oONn3eSFJLmAfTpbXbfsliXK5xef9m2B29Io7zO5duqRsour/+NmHtgBH+CL++cRxvW/45g4Xnx7sVCwVLmGUJ0fRLwwio8pCN9hyPvN9I7hjW31Q4m0krpKBo+r3JxrcmJt1/wgElRrxDMZ08VEOEaIiN4b19NdZETfuS7+7BB/SSCyQbnnzLD+RwcdSX7hw6CRtw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1205; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY1PR0301MB1205;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1205; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1205;3:6oy5XZoDl+EAH/abJeL6/mpAokjXyVm5NvMsQNkAKDO6480cjdW/a06O0EZVkLFGqJBaUecl8H/mMm8suN6vLLSEjLBQ6+Widextfs7NDS0E+NnFfSqI3PVnXc8jBPvzYnfyRYJt2GDhMOdPMuv7qdk3ottmcjYeMAKl1i35wLoMi2nBIBtCoWMFtmvjhN+SfPy15xrEx8bAtQbvA1pmoPm2bnvw4v5QM8V9PHCT9xPZgF+AFhAJikf4FLe00qP37bVQCPNRhlJlABmVfeuZvP/Ew0arapEAeeMsvQp/6afFiz886iGx0DDW0D47t7xs X-Forefront-PRVS: 0590BBCCBC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0301MB1205;9:y4d46qNKUh0kcdOSi7julOQJWrgCdQxXQXOTlFWN?= =?us-ascii?Q?bjNm2P373TV38vEgMY/YckEoe1umsLXw4I0ITQ+gytDMrhsdqdLhZ8HsS14x?= =?us-ascii?Q?APF3TzQlcfqRueIIGABYQGtK6PR902AcnsNXbI+dd6bYqjc2r9V4MfffNPIz?= =?us-ascii?Q?UYgN/8r1Ybyo5uTT0wJsChca8aqAOBoQnAC+TqWbUTpB7JIuP99LEO7CLiiT?= =?us-ascii?Q?BtiOpLaTEbTC5LB+UvMUbDkO8PH+E+Zfw51FSOuaC6vdh635EzQJIardwzGk?= =?us-ascii?Q?WNlDoyFuGbzfoB7ClxNyh8pe8VSF8EmQgcWoJ59jjjg37lT7x93454/PTwTj?= =?us-ascii?Q?2EUBSzJ401AriJ47McMH5wHetsokTe7Otk0qLAcdya4qvxerH8EAHWuWrUa+?= =?us-ascii?Q?EcD1/ijacf502dMRF128Rsm5rXC4yb8sOrbVyNHrMu7seOHWzeJZZpr8ORJ0?= =?us-ascii?Q?XZVT6oLJMFWrVGVVjVh+d4qwt53dRZChMXc9y9A3T3M+Y1MNvMW816CHdi9e?= =?us-ascii?Q?rRbUoZspBZbr6Zh2dfsh3kl51aBsKuPFFH5t6yMzMNv51n1ik3l27BA4Hukc?= =?us-ascii?Q?Vny6U0+nmtmX2ie/Z5utQGRz8UP2Etgo6Kof28CUu5lQJ5QGI+et+Q46w10E?= =?us-ascii?Q?f84Bw7M7iiUXmXRiN6iQqgO3+KtK+SlOC/s2P+ZCai6JdLS+P4RdSL/cDxLr?= =?us-ascii?Q?W1wVnoIEv2+BMRVKbAlTBv4xVtFUX9B38QrI7n547C0jm9e7GfI2827z3z+b?= =?us-ascii?Q?6fVDWruX9+0gWMzxxg8ms3NmEFW0/onL3QavbMYwpaQig2ydA/ISxydQXLrn?= =?us-ascii?Q?eTaoPHVUX5rpCJ8NfKoRYTMcwmi965xukaHLIs+QAw43NMeTrNMEsR/2JgMo?= =?us-ascii?Q?INE8SlR+XsBTZ27oNSQr+iUrTdmD3WykUPlhH+D2CEVCEczRqd5zEc3eYbam?= =?us-ascii?Q?Mj3GqmjqwtQvZEC5OkxXgwqg1l0HRIGzrjWO7sxlytXoDGXYp2hqrv5wX4Db?= =?us-ascii?Q?Sc9/8oeldhtbW5lwAd8Aotx4oywVYI7LfcTRrRdmUYhXB/YEhrZV0Jhxq2qK?= =?us-ascii?Q?h6uWS5S06fXZbjiTKGb9G/Q2OeXEAoPPKKxhYWf9DhG/zX6KNPibmYDHQnB2?= =?us-ascii?Q?qY5oUBBCxYKoReID5K+Ocm4msK9N5qBgCY8e46gcYAdpqLcv8ZdoVWWNX5If?= =?us-ascii?Q?GxCTLjDwgvJtmAieLE59vQwz4eEFPyiJTOF5mP4glzCmPsQrIWklpwLiV8GG?= =?us-ascii?Q?LHWLJJzThr2p0sy1woL1kTsfQbnm0rBhuktZBEXa3Oan6z/h88bSHk77MLJd?= =?us-ascii?Q?VTynXYeuz7v/nMbYL5NCuT29jluvncbbW7PZ6A1KtTJq?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1205;3:kjHFUwwIwmquRsW0F51XXM4duiClTnolGafNhMCo5tlYlOfXSHblIYxpMvE1KwMQxk3hpDezeLlxU1CpFc9FO8ACofCx9j7A2DN4Lpnye7EwpdTM6cszGmtko+VLaXbpY/jxs6ij5ZXr4eWQ0VSwXQ==;10:Bpa9q6caefzFSdQF5nau7yz5NZMGuSTjJ4mQF4Pzu+T0SWWb+MKnmSOkIe5BGwerTjNvYWHSBYYoIFnhOFPu6broeIHW+RPRmFaHM6N6974=;6:W7lWcYozjlsf+NQhTQhDBTp0jr6jbKI8COyZdt41+PmTxS40KlkSTT0mYEtk1ACI X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2015 08:26:29.1120 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1205 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > order of arguments in the success vs. error paths in this function. > > > > Cc: Mike Turquette > > Cc: Stephen Boyd > > Suggested-by: Stephen Boyd > > Signed-off-by: Dong Aisheng > > Patch looks good to me. > Thanks for the review. > Also just noticed that the second argument to __clk_set_parent_after is > never used :-( > Yes, before this patch series, it's never used. :) Regards Dong Aisheng > Regards, > Mike > > > --- > > drivers/clk/clk.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index 659f2b0..0e813ea 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > flags = clk_enable_lock(); > > clk_reparent(core, old_parent); > > clk_enable_unlock(flags); > > + __clk_set_parent_after(core, old_parent, parent); > > > > - if (core->prepare_count) { > > - flags = clk_enable_lock(); > > - clk_core_disable(core); > > - clk_core_disable(parent); > > - clk_enable_unlock(flags); > > - clk_core_unprepare(parent); > > - } > > return ret; > > } > > > > -- > > 1.9.1 > >