From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887AbbE1Lc1 (ORCPT ); Thu, 28 May 2015 07:32:27 -0400 Received: from casper.infradead.org ([85.118.1.10]:57297 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753704AbbE1LcU (ORCPT ); Thu, 28 May 2015 07:32:20 -0400 Date: Thu, 28 May 2015 13:32:14 +0200 From: Peter Zijlstra To: Madhavan Srinivasan Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Jiri Olsa , Sukadev Bhattiprolu , Michael Ellerman Subject: Re: [PATCH]perf/core: remove newline char in perf_event_sysfs_show Message-ID: <20150528113214.GF3644@twins.programming.kicks-ass.net> References: <1432805366-15854-1-git-send-email-maddy@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432805366-15854-1-git-send-email-maddy@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 02:59:26PM +0530, Madhavan Srinivasan wrote: > When a event also carries a event.unit file, having newline char > will make perf userspace tool to print the event name in > the next line when dumping counter data. And changing the kernel will break the API (it includes a '\n' now) so fix the tool.