From: Jiri Olsa <jolsa@redhat.com>
To: Rabin Vincent <rabin.vincent@axis.com>
Cc: acme@redhat.com, mingo@redhat.com, paulus@samba.org,
a.p.zijlstra@chello.nl, jolsa@kernel.org,
linux-kernel@vger.kernel.org, Rabin Vincent <rabinv@axis.com>
Subject: Re: [PATCH] perf: fix MIPS build
Date: Thu, 28 May 2015 14:03:18 +0200 [thread overview]
Message-ID: <20150528120318.GE12392@krava.redhat.com> (raw)
In-Reply-To: <1432813573-2204-1-git-send-email-rabin.vincent@axis.com>
On Thu, May 28, 2015 at 01:46:13PM +0200, Rabin Vincent wrote:
> 5e8c0fb6a ("perf build: Add arch x86 objects building") added empty
> Build files to several architectures, but MIPS got left out. This leads
> to a build of perf for MIPS failing with the following errors:
>
> tools/build/Makefile.build:40: arch/mips/Build: No such file or directory
> make[4]: *** No rule to make target `arch/mips/Build'. Stop.
>
> Add an empty Build file to fix this.
>
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> ---
> 0 files changed
> create mode 100644 tools/perf/arch/mips/Build
>
> diff --git a/tools/perf/arch/mips/Build b/tools/perf/arch/mips/Build
> new file mode 100644
> index 0000000..e69de29
> --
> 1.7.10.4
>
hum, haven't realized we're so strict ;-)
I haven't checked this deeply (and we'll probably take your change)
but could you please try attached patch if it solves the issue?
thanks,
jirka
---
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 10df57237a66..69c35cf09cad 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -37,7 +37,7 @@ subdir-obj-y :=
# Build definitions
build-file := $(dir)/Build
-include $(build-file)
+-include $(build-file)
quiet_cmd_flex = FLEX $@
quiet_cmd_bison = BISON $@
next prev parent reply other threads:[~2015-05-28 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 11:46 [PATCH] perf: fix MIPS build Rabin Vincent
2015-05-28 12:03 ` Jiri Olsa [this message]
2015-05-28 12:45 ` Rabin Vincent
2015-05-28 12:53 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528120318.GE12392@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox