From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbbE1MDa (ORCPT ); Thu, 28 May 2015 08:03:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41257 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbbE1MD3 (ORCPT ); Thu, 28 May 2015 08:03:29 -0400 Date: Thu, 28 May 2015 14:03:18 +0200 From: Jiri Olsa To: Rabin Vincent Cc: acme@redhat.com, mingo@redhat.com, paulus@samba.org, a.p.zijlstra@chello.nl, jolsa@kernel.org, linux-kernel@vger.kernel.org, Rabin Vincent Subject: Re: [PATCH] perf: fix MIPS build Message-ID: <20150528120318.GE12392@krava.redhat.com> References: <1432813573-2204-1-git-send-email-rabin.vincent@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432813573-2204-1-git-send-email-rabin.vincent@axis.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 01:46:13PM +0200, Rabin Vincent wrote: > 5e8c0fb6a ("perf build: Add arch x86 objects building") added empty > Build files to several architectures, but MIPS got left out. This leads > to a build of perf for MIPS failing with the following errors: > > tools/build/Makefile.build:40: arch/mips/Build: No such file or directory > make[4]: *** No rule to make target `arch/mips/Build'. Stop. > > Add an empty Build file to fix this. > > Signed-off-by: Rabin Vincent > --- > 0 files changed > create mode 100644 tools/perf/arch/mips/Build > > diff --git a/tools/perf/arch/mips/Build b/tools/perf/arch/mips/Build > new file mode 100644 > index 0000000..e69de29 > -- > 1.7.10.4 > hum, haven't realized we're so strict ;-) I haven't checked this deeply (and we'll probably take your change) but could you please try attached patch if it solves the issue? thanks, jirka --- diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build index 10df57237a66..69c35cf09cad 100644 --- a/tools/build/Makefile.build +++ b/tools/build/Makefile.build @@ -37,7 +37,7 @@ subdir-obj-y := # Build definitions build-file := $(dir)/Build -include $(build-file) +-include $(build-file) quiet_cmd_flex = FLEX $@ quiet_cmd_bison = BISON $@