From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbbE1MKF (ORCPT ); Thu, 28 May 2015 08:10:05 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33442 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbbE1MKA (ORCPT ); Thu, 28 May 2015 08:10:00 -0400 Date: Thu, 28 May 2015 14:09:54 +0200 From: Ingo Molnar To: Jiri Olsa Cc: Namhyung Kim , Andi Kleen , Sukadev Bhattiprolu , Ingo Molnar , Michael Ellerman , Arnaldo Carvalho de Melo , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file Message-ID: <20150528120954.GA8478@gmail.com> References: <1432080130-6678-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432080130-6678-3-git-send-email-sukadev@linux.vnet.ibm.com> <20150527135402.GA29557@danjae.kornet> <20150527144007.GL7484@tassilo.jf.intel.com> <20150528115223.GD12392@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150528115223.GD12392@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jiri Olsa wrote: > On Wed, May 27, 2015 at 11:59:04PM +0900, Namhyung Kim wrote: > > Hi Andi, > > > > On Wed, May 27, 2015 at 11:40 PM, Andi Kleen wrote: > > >> So we build tables of all models in the architecture, and choose > > >> matching one when compiling perf, right? Can't we do that when > > >> building the tables? IOW, why don't we check the VFM and discard > > >> non-matching tables? Those non-matching tables are also needed? > > > > > > We build it for all cpus in an architecture, not all architectures. > > > So e.g. for an x86 binary power is not included, and vice versa. > > > > OK. > > > > > It always includes all CPUs for a given architecture, so it's possible > > > to use the perf binary on other systems than just the one it was > > > build on. > > > > So it selects one at run-time not build-time, good. But I worry about > > the size of the intel tables. How large are they? Maybe we can make > > it dynamic-loadable if needed.. > > just compiled Sukadev's new version with Andi's events list > and stripped binary size is: > > [jolsa@krava perf]$ ls -l perf > -rwxrwxr-x 1 jolsa jolsa 2772640 May 28 13:49 perf > > > while perf on Arnaldo's perf/core is: > > [jolsa@krava perf]$ ls -l perf > -rwxrwxr-x 1 jolsa jolsa 2334816 May 28 13:49 perf > > seems not that bad It's not bad at all. Do you have a Git tree URI where I could take a look at its current state? A tree would be nice that has as many of these patches integrated as possible. Thanks, Ingo