[PATCH] perf: fix MIPS build

[PATCH] perf: fix MIPS build

[Rabin Vincent]

5e8c0fb6a ("perf build: Add arch x86 objects building") added empty
Build files to several architectures, but MIPS got left out.  This leads
to a build of perf for MIPS failing with the following errors:

 tools/build/Makefile.build:40: arch/mips/Build: No such file or directory
 make[4]: *** No rule to make target `arch/mips/Build'.  Stop.

Add an empty Build file to fix this.

Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
---
 0 files changed
 create mode 100644 tools/perf/arch/mips/Build

diff --git a/tools/perf/arch/mips/Build b/tools/perf/arch/mips/Build
new file mode 100644
index 0000000..e69de29
-- 
1.7.10.4

Re: [PATCH] perf: fix MIPS build

[Jiri Olsa]

On Thu, May 28, 2015 at 01:46:13PM +0200, Rabin Vincent wrote:
> 5e8c0fb6a ("perf build: Add arch x86 objects building") added empty
> Build files to several architectures, but MIPS got left out.  This leads
> to a build of perf for MIPS failing with the following errors:
> 
>  tools/build/Makefile.build:40: arch/mips/Build: No such file or directory
>  make[4]: *** No rule to make target `arch/mips/Build'.  Stop.
> 
> Add an empty Build file to fix this.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> ---
>  0 files changed
>  create mode 100644 tools/perf/arch/mips/Build
> 
> diff --git a/tools/perf/arch/mips/Build b/tools/perf/arch/mips/Build
> new file mode 100644
> index 0000000..e69de29
> -- 
> 1.7.10.4
> 

hum, haven't realized we're so strict ;-)

I haven't checked this deeply (and we'll probably take your change)
but could you please try attached patch if it solves the issue?

thanks,
jirka


---
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 10df57237a66..69c35cf09cad 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -37,7 +37,7 @@ subdir-obj-y :=
 
 # Build definitions
 build-file := $(dir)/Build
-include $(build-file)
+-include $(build-file)
 
 quiet_cmd_flex  = FLEX     $@
 quiet_cmd_bison = BISON    $@

Re: [PATCH] perf: fix MIPS build

[Rabin Vincent]

On Thu, May 28, 2015 at 02:03:18PM +0200, Jiri Olsa wrote:
> I haven't checked this deeply (and we'll probably take your change)
> but could you please try attached patch if it solves the issue?

Yes, that works too.  Thanks.

Re: [PATCH] perf: fix MIPS build

[Jiri Olsa]

On Thu, May 28, 2015 at 02:45:09PM +0200, Rabin Vincent wrote:
> On Thu, May 28, 2015 at 02:03:18PM +0200, Jiri Olsa wrote:
> > I haven't checked this deeply (and we'll probably take your change)
> > but could you please try attached patch if it solves the issue?
> 
> Yes, that works too.  Thanks.

cool, I'll double check if thats ok with the rest of the code
and post it.. or will take your change if not ;-)

thanks,
jirka