From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbbE1N6P (ORCPT ); Thu, 28 May 2015 09:58:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39511 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185AbbE1N6D (ORCPT ); Thu, 28 May 2015 09:58:03 -0400 Date: Thu, 28 May 2015 16:57:44 +0300 From: Dan Carpenter To: KY Srinivasan Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" Subject: Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues Message-ID: <20150528135744.GN11734@mwanda> References: <1432682469-15033-1-git-send-email-kys@microsoft.com> <20150528070613.GV11588@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 01:52:47PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > > Sent: Thursday, May 28, 2015 12:06 AM > > To: KY Srinivasan > > Cc: davem@davemloft.net; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > > apw@canonical.com; jasowang@redhat.com > > Subject: Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues > > > > Since you're redoing this anyway. > > > > On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote: > > > diff --git a/drivers/net/hyperv/hyperv_net.h > > b/drivers/net/hyperv/hyperv_net.h > > > index ddcc7f8..dd45440 100644 > > > --- a/drivers/net/hyperv/hyperv_net.h > > > +++ b/drivers/net/hyperv/hyperv_net.h > > > @@ -161,6 +161,7 @@ struct netvsc_device_info { > > > unsigned char mac_adr[ETH_ALEN]; > > > bool link_state; /* 0 - link up, 1 - link down */ > > > int ring_size; > > > + u32 max_num_vrss_chns; > > > > We (Joe and I) have commented before that long names don't mix well with > > the 80 character limit. You could just leave the "num_" out. Almost > > all variables are numbers in C so it doesn't add anything. > > Thanks Dan. Actually I sent out the revised patch yesterday and I currently don't > Have the 80 char issue. If it is ok with Dave, I will not re-spin the patch. However, I will > note this comment for future work. Yes. I saw that. Fine fine. It wasn't a redo the patch worthy comment. :P regards, dan carpenter