public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: corbet@lwn.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu,
	gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org,
	jkosina@suse.cz, bhelgaas@google.com, linux-pci@vger.kernel.org,
	xen-devel@lists.xenproject.org, bp@suse.de,
	"Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH] Documentation: extend use case for EXPORT_SYMBOL_GPL()
Date: Thu, 28 May 2015 21:07:49 +0100	[thread overview]
Message-ID: <20150528200749.GD7232@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1432839361-10308-1-git-send-email-mcgrof@do-not-panic.com>

On Thu, May 28, 2015 at 11:56:01AM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> Current documentation over use case for EXPORT_SYMBOL_GPL()
> only acknowledges functions which are "an internal implementation
> issue, and not really an interface". In practice these days
> though we have some maintainers taking on preferences to require
> all new functionality go in with EXPORT_SYMBOL_GPL().
> 
> A maintainer asking developers to use EXPORT_SYMBOL_GPL()
> for new functionality tends to be a well accepted and understood
> position that maintainers can take and typically requires the
> maintainers educating contributing developers on their own
> positions and requirements.
> 
> Developers who submit code to maintainers not familiar with
> these preferences as optional for new functionality need explicit
> guidence though as existing documentation does not acknowledge
> this as a valid possibility. Without this being documented some
> maintainers are reluctant to accept new functionality with
> EXPORT_SYMBOL_GPL().
> 
> This extends the use case documentation for EXPORT_SYMBOL_GPL()
> to acknowledge acceptance for new functionality.
 
... while some of us consider that as pointless posturing and will refuse
to merge such exports regardless.  It's _NOT_ a universal default; please,
do not attempt to imply otherwise.  In particular, for fs/*.c I will not
accept that as valid grounds for use of EXPORT_SYMBOL_GPL.

  parent reply	other threads:[~2015-05-28 20:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 18:56 [PATCH] Documentation: extend use case for EXPORT_SYMBOL_GPL() Luis R. Rodriguez
2015-05-28 19:09 ` Jonathan Corbet
2015-05-28 19:18   ` Luis R. Rodriguez
2015-05-28 19:35     ` Jonathan Corbet
2015-05-28 20:07 ` Al Viro [this message]
2015-05-28 21:17   ` Luis R. Rodriguez
2015-05-28 21:56     ` Al Viro
2015-05-28 23:10       ` Luis R. Rodriguez
2015-05-29  5:00         ` Christoph Hellwig
2015-05-29 17:40           ` Luis R. Rodriguez
2015-05-29  1:30 ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150528200749.GD7232@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=bhelgaas@google.com \
    --cc=bp@suse.de \
    --cc=corbet@lwn.net \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    --cc=mcgrof@suse.com \
    --cc=mingo@elte.hu \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox