From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755423AbbE2Gf4 (ORCPT ); Fri, 29 May 2015 02:35:56 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44521 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755017AbbE2Gfs (ORCPT ); Fri, 29 May 2015 02:35:48 -0400 Date: Fri, 29 May 2015 08:35:38 +0200 From: Sascha Hauer To: Matthias Brugger Cc: mturquette@linaro.org, sboyd@codeaurora.org, henryc.chen@mediatek.com, jamesjj.liao@mediatek.com, p.zabel@pengutronix.de, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] clk: Add regmap support for clk mulitplexer Message-ID: <20150529063538.GZ6325@pengutronix.de> References: <1432838508-5184-1-git-send-email-matthias.bgg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432838508-5184-1-git-send-email-matthias.bgg@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:29:57 up 73 days, 18:21, 99 users, load average: 0.00, 0.09, 0.12 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 08:41:45PM +0200, Matthias Brugger wrote: > This patch set adds regmap support for the simple clock multiplexer. > Regmap use, apart from a pointer to the regmap struct needs an > offset value to know where in the regmap it has to read/write. > We add both fields to struct clk_mux. > > The driver will distinguish between a clock which is based on regmap or not > through a flag specified for the mux. > The approach does not break the existing clock framework API but adds two > new functions for registering regmap clocks. Unregistering the clocks is > independent of the use of regmap or not, so that no new function was > implemented. > > As an example user of the regmap clock multiplexer, it was implemented on > the mt8135. When accepted it will also be applied to the other Mediatek SoCs. > Other possible user are Qualcomm SoCs which up to now implement their own > regmap based clock multiplexer. I'm all in for providing regmap support for the basic clk providers. >>From digging through the archives I found out that the last try failed, so I hesitated to implement this for Mediatek. I hope it's time to revisit this. Using regmap would make the basic clock providers much more versatilely usable. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |