From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754924AbbE2GpU (ORCPT ); Fri, 29 May 2015 02:45:20 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36739 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbbE2GpN (ORCPT ); Fri, 29 May 2015 02:45:13 -0400 Date: Fri, 29 May 2015 08:45:08 +0200 From: Ingo Molnar To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH] perf tools: Make Ctrl-C stop processing on TUI Message-ID: <20150529064508.GB22749@gmail.com> References: <1432856452-10631-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432856452-10631-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Namhyung Kim wrote: > It was inconvenient that perf cannot be quit with SIGINT during > processing samples on TUI especially for large data files. > > This was because the first argument of SLang_init_tty(), abort_char, > being 0. The manual says it's the ascii value of the control > character that will be used to generate the interrupt signal [1]. > Passing -1 means to use the default value (Ctrl-C). > > [1] http://jedsoft.org/slang/doc/html/cslang-6.html#ss6.1 > > Signed-off-by: Namhyung Kim > --- > tools/perf/ui/tui/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c > index b77e1d771363..60d1f29b4b50 100644 > --- a/tools/perf/ui/tui/setup.c > +++ b/tools/perf/ui/tui/setup.c > @@ -129,7 +129,7 @@ int ui__init(void) > err = SLsmg_init_smg(); > if (err < 0) > goto out; > - err = SLang_init_tty(0, 0, 0); > + err = SLang_init_tty(-1, 0, 0); > if (err < 0) > goto out; Will this change the current Ctrl-C behavior in other places in any way? Right now Ctrl-C behavior is pretty sensible: it essentially means instant abort of whatever was done, i.e. stepping back a level in 'perf top', exit the app if it's done at the highest level. I hope that's preserved! :-) Thanks, Ingo