From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755575AbbE2JUw (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 May 2015 05:20:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57416 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754162AbbE2JUl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 May 2015 05:20:41 -0400
Date: Fri, 29 May 2015 11:13:15 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: mingo@redhat.com, ak@linux.intel.com,
        Michael Ellerman <mpe@ellerman.id.au>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Paul Mackerras <paulus@samba.org>, namhyung@kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile
Message-ID: <20150529091140.GA20512@krava.redhat.com>
References: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com>
 <1432761809-4344-5-git-send-email-sukadev@linux.vnet.ibm.com>
 <20150528124221.GK12392@krava.redhat.com>
 <20150529054506.GA3088@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150529054506.GA3088@us.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote:
> Jiri Olsa [jolsa@redhat.com] wrote:
> | >  		if (line[0] == '#' || line[0] == '\n')
> | >  			continue;
> | > +		if (!strncmp(line, "Family", 6))
> | > +			continue;
> | 
> | I think we should fix mapfiles to put the 'Family' starting
> | line as a comment.. the way powerpc mapfile is done
> 
> You mean add something like this to the Intel mapfile:
> 
> 	# Power8 entries
> 	004d0100,1,power8.json,core
> 
> and drop this patch?

right

jirka