public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	cfreeman@nvidia.com, abrestic@chromium.org, afrid@nvidia.com
Subject: Re: [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver
Date: Fri, 29 May 2015 10:49:41 +0100	[thread overview]
Message-ID: <20150529094941.GL21577@sirena.org.uk> (raw)
In-Reply-To: <5567FE68.5070006@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Fri, May 29, 2015 at 11:21:36AM +0530, Laxman Dewangan wrote:

> In our system, CPU-DFLL is another HW module which controls the CPU voltage
> based on CPU frequency request. It issues the i2c command to the device for
> voltage change when frequency get change. For this reason, CPU-DFLL need the
> VSEL register address. The CPU DVFS SW driver controls the DVS input pin to
> control sleep entry/exit and VOUT0 for voltage change. So on this case, we
> really donot need to change the VSEL register address for active state
> voltage change and use the DVS for sleep entry/exit.

Sure, that's the normal use case for this stuff.

> The problem will be there when external controller use the DVS pin for DVFS
> and need two register address here. In this case, I think external
> controller need to get information from different mechanism rather than via
> regulator driver to avoid complication on regulator driver/framework.

Probably, it's definitely getting complicated (though in this case where
we only need one register we ought to be more able to manage it, not
that I have bright ideas right now).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-05-29  9:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 14:40 [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver Laxman Dewangan
2015-05-27 14:40 ` [PATCH 2/2] regulator: max8973: Implement callback to get vsel and mask Laxman Dewangan
2015-05-28 13:52 ` [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver Mark Brown
2015-05-29  5:51   ` Laxman Dewangan
2015-05-29  9:49     ` Mark Brown [this message]
2015-05-29 11:43       ` Laxman Dewangan
2015-06-05 13:36       ` Laxman Dewangan
2015-06-05 16:58         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529094941.GL21577@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=abrestic@chromium.org \
    --cc=afrid@nvidia.com \
    --cc=cfreeman@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox