From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755772AbbE2Kfg (ORCPT ); Fri, 29 May 2015 06:35:36 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:48408 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180AbbE2Kf3 (ORCPT ); Fri, 29 May 2015 06:35:29 -0400 Date: Fri, 29 May 2015 12:35:23 +0200 From: Heiko Carstens To: Nicholas Mc Guire Cc: Nicholas Mc Guire , Michael Holzheu , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value Message-ID: <20150529103523.GB4169@osiris> References: <1432746283-8068-1-git-send-email-hofrat@osadl.org> <20150529090715.GA4169@osiris> <20150529095154.GB9952@opentech.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529095154.GB9952@opentech.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052910-0025-0000-0000-0000055CFEA4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Heiko Carstens wrote: > > Yes, the orginal code seems to be broken. Since I've no idea what the intended > > timeout value should be, let's simply ask Michael, who wrote this code eight > > years ago ;) > > While these lines get touched anyway, it would make sense to use > > schedule_timeout_interruptible() instead, and get rid of set_current_state(). > > > Well that is not really equivalent > schedule_timeout_interruptible() is doing > __set_current_state not set_current_state > so that would drop the mb() and no WRITE_ONCE() And how does that matter in this case?