From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030222AbbE2KEj (ORCPT ); Fri, 29 May 2015 06:04:39 -0400 Received: from mx3.wp.pl ([212.77.101.10]:54829 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030199AbbE2KEb (ORCPT ); Fri, 29 May 2015 06:04:31 -0400 Date: Fri, 29 May 2015 12:04:21 +0200 From: Jakub =?UTF-8?B?S2ljacWEc2tp?= To: Bhuvanchandra DV Cc: , , , , , , , , , Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl Message-ID: <20150529120421.754fd6ab@north> In-Reply-To: <1432886754-30115-3-git-send-email-bhuvanchandra.dv@toradex.com> References: <1432886754-30115-1-git-send-email-bhuvanchandra.dv@toradex.com> <1432886754-30115-3-git-send-email-bhuvanchandra.dv@toradex.com> X-Mailer: Claws Mail 3.11.1-85-ga87522 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [geOU] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote: > The LPUART does not provide manual control of RTS/CTS signals, > those can only be controlled by the hardware directly. Therefore > manual control of those signals through mctrl can not be provided. > The current implementation enables/disables the automatic control, > which is not what mctrl should do, hence remove the incorrect > implementation. > > Signed-off-by: Bhuvanchandra DV Now that the functions do nothing there is probably no point in keeping separate lpuart/lpuart32 variants.