From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbbE2NaG (ORCPT ); Fri, 29 May 2015 09:30:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:47486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035AbbE2N37 (ORCPT ); Fri, 29 May 2015 09:29:59 -0400 Date: Fri, 29 May 2015 10:29:55 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Wang Nan , linux-kernel@vger.kernel.org, lizefan@huawei.com, mingo@redhat.com Subject: Re: [PATCH tip/perf/core] perf probe: Fix 'function unused' warning Message-ID: <20150529132955.GR24859@kernel.org> References: <1432779905-206143-1-git-send-email-wangnan0@huawei.com> <5566A731.9090707@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5566A731.9090707@hitachi.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 28, 2015 at 02:27:13PM +0900, Masami Hiramatsu escreveu: > On 2015/05/28 11:25, Wang Nan wrote: > > By 'make build-test' a warning is found in probe-event.c that, after > > commit 419e873828 (perf probe: Show the error reason comes from > > invalid DSO) the only user of kernel_get_module_dso() is > > open_debuginfo(). Which is not compiled if HAVE_DWARF_SUPPORT not set. > > 'make build-test' found this problem when make_minimal. > > Ah, right! > > > > > This patch moves kernel_get_module_dso() to HAVE_DWARF_SUPPORT ifdef > > section. > > > > Signed-off-by: Wang Nan > > Acked-by: Masami Hiramatsu Thanks, applied! - Arnaldo