From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161057AbbE2PNn (ORCPT ); Fri, 29 May 2015 11:13:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:55451 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030190AbbE2PN1 (ORCPT ); Fri, 29 May 2015 11:13:27 -0400 Date: Fri, 29 May 2015 12:13:22 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: "Wangnan (F)" , Namhyung Kim , lizefan@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: introduce arm64 support unwind test. Message-ID: <20150529151322.GW24859@kernel.org> References: <1427461681-72971-1-git-send-email-wangnan0@huawei.com> <5566C106.4070706@huawei.com> <20150528134314.GF24859@kernel.org> <20150529092119.GA20737@krava.redhat.com> <20150529133255.GS24859@kernel.org> <20150529144024.GC14918@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529144024.GC14918@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 29, 2015 at 04:40:24PM +0200, Jiri Olsa escreveu: > On Fri, May 29, 2015 at 10:32:55AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, May 29, 2015 at 11:21:19AM +0200, Jiri Olsa escreveu: > > > On Thu, May 28, 2015 at 10:43:14AM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Thu, May 28, 2015 at 03:17:26PM +0800, Wangnan (F) escreveu: > > > > > Ping? > > > > > > Jiri, Ack? > > > > > yep, I've already ack-ed that.. should be on the lkml somewhere ;-) > > > > > > And from a quick look, isn't this better split in two pieces, i.e. the > > > > first wiring up ARM64 to libunwing, i.e. all those perf_regs.h files > > > > being added to tools/perf/arch/arm64/, and then a second patch, enabling > > > > the dwarf unwind 'perf test' entry to run on ARM64? > > > > > I guess.. but the change is fairly small, so it did not occur > > > to me as necessary.. > > > > :-) > > > > I felt mislead when looking at the subject, i.e. "hey, a new test, > > testing unwind on arm64", no, it wasn't that, it introduces support for > > unwind on ARM64 by providing that regs mapping, then it _enables_ an > > existing test on arm64 :-\ > > still it's good news right? ;-) Whatever, I'll fix at least the cset log message and apply... - Arnaldo