From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756909AbbE2Qrx (ORCPT ); Fri, 29 May 2015 12:47:53 -0400 Received: from hofr.at ([212.69.189.236]:48217 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756652AbbE2Qra (ORCPT ); Fri, 29 May 2015 12:47:30 -0400 Date: Fri, 29 May 2015 18:47:28 +0200 From: Nicholas Mc Guire To: Ian Abbott Cc: Nicholas Mc Guire , H Hartley Sweeten , Greg Kroah-Hartman , Davidlohr Bueso , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible() Message-ID: <20150529164728.GA11892@opentech.at> References: <1432915098-27097-1-git-send-email-hofrat@osadl.org> <55689582.1000700@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55689582.1000700@mev.co.uk> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015, Ian Abbott wrote: > On 29/05/15 16:58, Nicholas Mc Guire wrote: >> API consolidation with coccinelle found: >> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: >> consolidation with schedule_timeout_*() recommended >> >> This is a 1:1 conversion of the current calls to an available helper >> only - so only an API consolidation to improve readability. >> >> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, >> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m >> >> Patch is against 4.1-rc5 (localversion-next is -next-20150529) > > Minor niggle: you don't really need to say what version the patch is > against in the commit message, as the version will have changed by the > time the patch is committed. It can be mentioned after the "---" marker > line if relevant, as the stuff after the "---" line does not end up in > the commit message. > makes sense - will move that down for the other cleanups. thx! hofrat