From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Lidza Louina <lidza.louina@gmail.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type
Date: Fri, 29 May 2015 20:05:22 +0300 [thread overview]
Message-ID: <20150529170522.GP28762@mwanda> (raw)
In-Reply-To: <1432917688-20228-2-git-send-email-hofrat@osadl.org>
On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> The schedule_timeout*() helpers take the timeout as signed long, as
> ch_close_delay in struct channel_t was not used for other purposes its
> type was switched to signed long and the declarations fixed up.
Uh, we never pass it to schedule_timeout etc and even if we did how
would that matter? It's either 250 or 0.
What is the bug you are trying to fix and we can help you?
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-29 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 16:41 [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible() Nicholas Mc Guire
2015-05-29 16:41 ` [PATCH 2/2] staging: dgnc: switch timeout to signed type Nicholas Mc Guire
2015-05-29 17:05 ` Dan Carpenter [this message]
2015-05-29 17:21 ` Nicholas Mc Guire
2015-05-29 19:01 ` Dan Carpenter
2015-05-29 19:13 ` Nicholas Mc Guire
2015-05-31 1:25 ` [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible() Greg Kroah-Hartman
2015-05-31 5:54 ` Nicholas Mc Guire
2015-05-31 6:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529170522.GP28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox