From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770AbbE2TCV (ORCPT ); Fri, 29 May 2015 15:02:21 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36474 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbbE2TCP (ORCPT ); Fri, 29 May 2015 15:02:15 -0400 Date: Fri, 29 May 2015 22:01:34 +0300 From: Dan Carpenter To: Nicholas Mc Guire Cc: devel@driverdev.osuosl.org, Lidza Louina , driverdev-devel@linuxdriverproject.org, Nicholas Mc Guire , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type Message-ID: <20150529190134.GQ28762@mwanda> References: <1432917688-20228-1-git-send-email-hofrat@osadl.org> <1432917688-20228-2-git-send-email-hofrat@osadl.org> <20150529170522.GP28762@mwanda> <20150529172126.GA27992@opentech.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529172126.GA27992@opentech.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 07:21:26PM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Dan Carpenter wrote: > > > On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote: > > > The schedule_timeout*() helpers take the timeout as signed long, as > > > ch_close_delay in struct channel_t was not used for other purposes its > > > type was switched to signed long and the declarations fixed up. > > > > Uh, we never pass it to schedule_timeout etc and even if we did how > > would that matter? It's either 250 or 0. > > > > What is the bug you are trying to fix and we can help you? > > > static code checkers being unhappy with type mismatch > automatic type conversion is ok if necessary but in this > case it simply is not as the ch_close_delay is only being > used in this one place so why not do it type clean ? This seems like a pointless warning. What does the warning look like? We pass ms to msecs_to_jiffies() and not to schedule_timeout() so it seems like somewhere something is confused. > I'll turn the question around - what reason would there be to > go through type conversion if it is not needed ? You can go crazy if you do ever pointless change which a static analysis tool suggests... Btw, Smatch says that "ms" is always 250 here, actually. I was guessing earlier when I said it could be zero. Get a smarter static checker which can read code. :P regards, dan carpenter