From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756960AbbE2TNo (ORCPT ); Fri, 29 May 2015 15:13:44 -0400 Received: from hofr.at ([212.69.189.236]:48893 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756444AbbE2TNj (ORCPT ); Fri, 29 May 2015 15:13:39 -0400 Date: Fri, 29 May 2015 21:13:37 +0200 From: Nicholas Mc Guire To: Dan Carpenter Cc: devel@driverdev.osuosl.org, Lidza Louina , driverdev-devel@linuxdriverproject.org, Nicholas Mc Guire , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type Message-ID: <20150529191337.GA30160@opentech.at> References: <1432917688-20228-1-git-send-email-hofrat@osadl.org> <1432917688-20228-2-git-send-email-hofrat@osadl.org> <20150529170522.GP28762@mwanda> <20150529172126.GA27992@opentech.at> <20150529190134.GQ28762@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529190134.GQ28762@mwanda> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015, Dan Carpenter wrote: > On Fri, May 29, 2015 at 07:21:26PM +0200, Nicholas Mc Guire wrote: > > On Fri, 29 May 2015, Dan Carpenter wrote: > > > > > On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote: > > > > The schedule_timeout*() helpers take the timeout as signed long, as > > > > ch_close_delay in struct channel_t was not used for other purposes its > > > > type was switched to signed long and the declarations fixed up. > > > > > > Uh, we never pass it to schedule_timeout etc and even if we did how > > > would that matter? It's either 250 or 0. > > > > > > What is the bug you are trying to fix and we can help you? > > > > > static code checkers being unhappy with type mismatch > > automatic type conversion is ok if necessary but in this > > case it simply is not as the ch_close_delay is only being > > used in this one place so why not do it type clean ? > > This seems like a pointless warning. What does the warning look like? > We pass ms to msecs_to_jiffies() and not to schedule_timeout() so it > seems like somewhere something is confused. Not really - just my carelessness - the msecs_to_jiffies was not in there and I fixed up the types first - then put the msecs_to_jiffies in there to fix up the time conversion ...oh well took the type conversion out just to put it back in my self...sorry thats a bit braindead. thanks for catching that. > > > I'll turn the question around - what reason would there be to > > go through type conversion if it is not needed ? > > You can go crazy if you do ever pointless change which a static analysis > tool suggests... > > Btw, Smatch says that "ms" is always 250 here, actually. I was guessing > earlier when I said it could be zero. Get a smarter static checker > which can read code. wont blame it on coccinelle - its my scripts that are to blame - but in this case it was the cleanup after the fix for the warning that broke it. so 2/2 is pointless - sorry for that - pleas just toss it. thx! hofrat