From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422701AbbE2TXX (ORCPT ); Fri, 29 May 2015 15:23:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34356 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422661AbbE2TXQ (ORCPT ); Fri, 29 May 2015 15:23:16 -0400 Date: Fri, 29 May 2015 21:23:03 +0200 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4 errors Message-ID: <20150529192303.GS31435@pd.tnic> References: <1432753418-2985-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1432753418-2985-7-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150529160039.GJ31435@pd.tnic> <5568B570.5080106@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5568B570.5080106@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 01:52:32PM -0500, Aravind Gopalakrishnan wrote: > Yeah, I do run checkpatch. With this, I think the line was going above 79 > chars. So split it. Yeah, don't take checkpatch too seriously - only as a hint. Common sense should be employed, instead. :) > I thought we split such error messages right? Right, so string error messages we do not split for easier grepping. > (amd64_edac and mce_amd.c for example have such instances) Yeah, those will have to be fixed gradually when we're touching the code anyway, at some point. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --