From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757253AbbE2UAP (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 May 2015 16:00:15 -0400
Received: from down.free-electrons.com ([37.187.137.238]:45537 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1757213AbbE2UAF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 May 2015 16:00:05 -0400
Date: Fri, 29 May 2015 21:57:40 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>,
        kernel list <linux-kernel@vger.kernel.org>, dmitry.torokhov@gmail.com,
        Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Subject: Re: 4.1 touchscreen regression on n900 -- pinpointed [was Re:
 linux-n900 v4.1-rc4]
Message-ID: <20150529195740.GA17267@lukather>
References: <201505241444.41039@pali>
 <20150527132545.GA23434@amd>
 <20150527133311.GJ30798@pali>
 <20150527143722.GA28108@amd>
 <20150527145837.GA13223@earth>
 <20150529190816.GA20232@amd>
 <20150529192505.GA28987@amd>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb"
Content-Disposition: inline
In-Reply-To: <20150529192505.GA28987@amd>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 29, 2015 at 09:25:05PM +0200, Pavel Machek wrote:
> On Fri 2015-05-29 21:08:16, Pavel Machek wrote:
> > Hi!
> >=20
> > > mh I remember having problems with tsc2005 before. It helped to
> > > reset the controller (should actually happen automatically when it
> > > hangs, but I'm not sure, that it actually works).
> >=20
> > Ok, I did some more testing, and found out rather bogus values in
> > evtest:
> >=20
> > Input device name: "TSC2005 touchscreen"
> > Supported events:
> >   Event type 0 (EV_SYN)
> >   Event type 1 (EV_KEY)
> >   Event code 330 (BTN_TOUCH)
> >   Event type 3 (EV_ABS)
> >   Event code 0 (ABS_X)
> >   Value   2514
> >  Min        0
> >  Max        0
> >  Fuzz       4
> >=20
> > Which made me go through the git logs, and these patches looked
> > suspicious. After a revert... yes, touchscreen works as well as it
> > worked before.
> >=20
> > 0a363a380954e10fece7cd9931b66056eeb07d56
> > 3eea8b5d68c801fec788b411582b803463834752
> >=20
> > (It is impossible to revert just 3eea..)
>=20
> Hmm, I see:
>=20
>                 touchscreen-max-x =3D <4096>;
>                 touchscreen-max-y =3D <4096>;
> ...that's n900 dts.. this should be size-x/size-y... so we have a bug
> in dts.
>=20
> But the 3eea8b5d68c801fec788b411582b803463834752 is buggy, it should
> not overwrite ->maximum for axis it has no devicetree data for.

What do you mean? touchscreen-max-* _is_ device tree data for an axis.

> Maybe replacing
>=20
> +       if (maximum || fuzz)
>=20
> in 3eea to (maximum && fuzz)... would help, but it is late in the
> cycle now, so I'd suggest just reverting 3eea8b.

No, both maximum and fuzz are optional. You can perfectly have one
without another.

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--VS++wcV0S1rZb1Fb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVaMS0AAoJEBx+YmzsjxAg3LEQAIaq33vDN5xDD8sx6ReXxDva
d7J0M/EdalVOpL6fv8Mm8MAAQeZMwCWMsBc+yb/sR1CtqUT3xbgXORPfGWY/RlC4
WHbIOERkshmS0Miz3sbsIw70h9LOHI0EzGJ56GOnDeImJsvxNyaXtSW4H5CbYRfq
kijhtaJ/N+S2fQXHguTwJ6hXIcf6EIPaE2J4VrR50roZ2AR5Qr2Aejkk12pinAF2
v60VLNzemnzO+dgfN+FPxczdmNKbluLcm4ZFD2CFZo3lTFnDFLSXyR6miDNDmbub
Rx2eo60ry4JHIVaJODJwLp4mb0wLGaBn5+72FeGvjSlMzE1m2uYfT/9OR9rrTdaK
w5XTxkpwoc/duiSF28+qArIXO1wUOX0cKOmlieo3MYY4OKI8/bGTMaD1F2qwftxC
kV8jupJ47vWQ8PI1QFm8t5gFCnDEQWLwL6j+lSIhBcUkYgNpmfVbt7J3tX0MLnH7
zCZk9SG/vRZ8f3YaW/7S6pTf4S9mF+WbYmXvbrnKmq+2fPhmm8coa9GTWJT+woOr
OGldiN+YgwZ7UlRdtu6pIaMu4DmKWOZW9/IpP9W2wN3KDTpC4wDWBLGLo7Ema/fG
x9NvXqDYg94asmH1ced/+3jezJBXxBBUv4MjCREC9+mOSLeJ5PESYhnRM0duNPRB
7kLsRGotpmx95nLgBGQE
=SFaf
-----END PGP SIGNATURE-----

--VS++wcV0S1rZb1Fb--