Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

Sebastian Reichel
2015-05-30T02:21:49Z

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

Hi,

On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote:
> Fix dts to match what the Linux kernel expects. This works around
> touchscreen problems in 4.1 linux on Nokia n900.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> index 4b641c7..09089a6 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> @@ -32,8 +32,8 @@ Example:
> touchscreen-fuzz-x = <4>;
> touchscreen-fuzz-y = <7>;
> touchscreen-fuzz-pressure = <2>;
> - touchscreen-max-x = <4096>;
> - touchscreen-max-y = <4096>;
> + touchscreen-size-x = <4096>;
> + touchscreen-size-y = <4096>;
> touchscreen-max-pressure = <2048>;
>
> ti,x-plate-ohms = <280>;
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 5c16145..5f5e0f3 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -832,8 +832,8 @@
> touchscreen-fuzz-x = <4>;
> touchscreen-fuzz-y = <7>;
> touchscreen-fuzz-pressure = <2>;
> - touchscreen-max-x = <4096>;
> - touchscreen-max-y = <4096>;
> + touchscreen-size-x = <4096>;
> + touchscreen-size-y = <4096>;
> touchscreen-max-pressure = <2048>;
>
> ti,x-plate-ohms = <280>;

Acked-By: Sebastian Reichel <sre@kernel.org>

max-x/fuzz-x is a leftover from development of the generic bindings
(Initially I used min and max).

If 3eea8b5d68c801fec788b411582b803463834752's behaviour should
become the new behaviour it should be documented, that maximum and
fuzz values are dependent on each other. Instead I suggest to
restore the old behaviour.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]