From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422729AbbE2U1k (ORCPT ); Fri, 29 May 2015 16:27:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422659AbbE2U1T (ORCPT ); Fri, 29 May 2015 16:27:19 -0400 Date: Fri, 29 May 2015 15:27:16 -0500 From: Josh Poimboeuf To: Andy Lutomirski Cc: Ingo Molnar , Jan Beulich , Borislav Petkov , Peter Zijlstra , Ingo Molnar , Brian Gerst , =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Thomas Gleixner , Linus Torvalds , Denys Vlasenko , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , Masami Hiramatsu , "Frank Ch. Eigler" , Dave Anderson , x86@kernel.org Subject: Re: [PATCH] x86/debug: Remove perpetually broken, unmaintainable dwarf annotations Message-ID: <20150529202716.GA24561@treble.redhat.com> References: <5566EBE7020000780007E659@mail.emea.novell.com> <20150528090133.GA469@gmail.com> <5566FFDD020000780007E711@mail.emea.novell.com> <20150528112017.GA28196@gmail.com> <55671D63020000780007E885@mail.emea.novell.com> <20150528131743.GA9496@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 10:47:31AM -0700, Andy Lutomirski wrote: > On Thu, May 28, 2015 at 6:17 AM, Ingo Molnar wrote: > > * Jan Beulich wrote: > >> > and meanwhile you can keep a revert of this patch ported to SUSE kernels in > >> > whatever fashion you prefer. > >> > >> Funny suggestion - I don't think that's reasonable for us to do. Or if we were > >> to, we could as well invest in doing the re-work you're asking for; I don't > >> think anyone will have the time to do either. > > > > That's fair enough: if there's not enough resources to keep a feature maintainable > > upstream then it should not be upstream in that form. > > > > This isn't just some driver we can let bit-rot in peace until it finds a > > maintainer (or not), without affecting anyone but users of that driver. > > > > This is hundreds of usage sites of ugly code intermixed with critical pieces of > > assembly code that negatively affects the hackability of everything. > > > > Also, with the feature missing completely, maybe someone finds a method to > > introduce it in a maintainable fashion, while with the feature included upstream > > there's very little pressure to do that. As a bonus we'd also win a workable dwarf > > unwinder. > > Before doing something drastic like this, I think we should get Josh's > opinion, since I think he's working on a new (?) unwinder. I'd definitely like to replace all the asm DWARF CFI annotations with something more automated and robust. So it doesn't really affect me whether they're ripped out now or replaced later. But it might be a few months before I have the code. If they get ripped out now, it might affect those tools which rely on debuginfo like perf, kprobes, systemtap, gdb, crash, etc. Then again, I'm not sure how useful or reliable the existing annotations are anyway, so maybe it doesn't matter much. CCing some possible consumers of kernel x86 DWARF data to see if they have any opinions. -- Josh