* [PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c
@ 2015-05-27 9:05 Simon Guo
2015-05-30 5:32 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Simon Guo @ 2015-05-27 9:05 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Liang Zhen,
Hema Prathaban, Julia Lawall, Melike Yurtoglu, Joe Perches,
Christopher J. Morrone
Cc: HPDD-discuss, devel, linux-kernel, Simon Guo
Delare request_cache variable as static. It is only used by
drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common
which will lead to namespace pollution.
Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c
index 45b7af7..347110e 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/client.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
@@ -390,7 +390,7 @@ static int ptlrpc_at_recv_early_reply(struct ptlrpc_request *req)
return rc;
}
-struct kmem_cache *request_cache;
+static struct kmem_cache *request_cache;
int ptlrpc_request_cache_init(void)
{
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c
2015-05-27 9:05 [PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c Simon Guo
@ 2015-05-30 5:32 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2015-05-30 5:32 UTC (permalink / raw)
To: Simon Guo
Cc: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Liang Zhen,
Hema Prathaban, Julia Lawall, Melike Yurtoglu, Joe Perches,
Christopher J. Morrone, HPDD-discuss, devel, linux-kernel
On Wed, May 27, 2015 at 05:05:26PM +0800, Simon Guo wrote:
> Delare request_cache variable as static.
Is it Declare?
regards
sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-30 5:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 9:05 [PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c Simon Guo
2015-05-30 5:32 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox