From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757525AbbE3GrL (ORCPT ); Sat, 30 May 2015 02:47:11 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34185 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbbE3GrE (ORCPT ); Sat, 30 May 2015 02:47:04 -0400 Date: Sat, 30 May 2015 12:16:54 +0530 From: Sudip Mukherjee To: Arnd Bergmann Cc: Greg KH , Rachel Kim , Dean Lee , Chris Park , devel@driverdev.osuosl.org, nicolas.ferre@atmel.com, Johnny Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/16] staging: wilc1000: remove semaphore wrapper Message-ID: <20150530064654.GF31685@sudip-PC> References: <1432932747-3739705-1-git-send-email-arnd@arndb.de> <1432932747-3739705-15-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432932747-3739705-15-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote: > The various semaphore functions all directly translate into > sema_init(), down() and up(), so we can just remove the API. > > This is a mostly automated conversion using simple sed scripts, > plus some manual changes to account for down() returning no > error. > > As a positive side-effect, down() no longer hangs after > receiving a signal, as the original code did by looping around > down_interruptible. > > The semaphores still need to be turned into mutexes as a > follow-up step. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/wilc1000/coreconfigurator.c | 29 +--- > drivers/staging/wilc1000/fifo_buffer.c | 108 +++++++------- > drivers/staging/wilc1000/fifo_buffer.h | 2 +- > drivers/staging/wilc1000/host_interface.c | 171 +++++++++------------- > drivers/staging/wilc1000/host_interface.h | 16 +- > drivers/staging/wilc1000/wilc_msgqueue.c | 32 ++-- > drivers/staging/wilc1000/wilc_oswrapper.h | 3 - > drivers/staging/wilc1000/wilc_platform.h | 4 +- > drivers/staging/wilc1000/wilc_semaphore.c | 56 ------- > drivers/staging/wilc1000/wilc_semaphore.h | 99 ------------- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 35 ++--- > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 +- > 12 files changed, 160 insertions(+), 399 deletions(-) > delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.c > delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.h wilc_semaphore still remains in the Makefile. regards sudip