From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] s390/sclp: pass timeout as HZ independent value
Date: Sat, 30 May 2015 13:45:32 +0200 [thread overview]
Message-ID: <20150530114532.GB4218@osiris> (raw)
In-Reply-To: <1432911055-23219-1-git-send-email-hofrat@osadl.org>
On Fri, May 29, 2015 at 04:50:55PM +0200, Nicholas Mc Guire wrote:
> schedule_timeout takes a timeout in jiffies but the code currently is
> passing in a constant SDIAS_SLEEP_TICKS, as this is otherwise unused
> it is replaced by 500ms as recommended by Michael Holzheu
> <holzheu@linux.vnet.ibm.com> and converted with msecs_to_jiffies();
> As SDIAS_SLEEP_TICKS was only used in this one location it is dropped.
>
> Patch was compile tested with (s390) defconfig +
> CONFIG_MARCH_Z10=y, (implies CONFIG_CRASH_DUMP=y)
>
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
>
> Link: http://lkml.org/lkml/2015/5/29/235
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> V2: timeout clarified by Heiko Carstens <heiko.carstens@de.ibm.com> and
> set to 500ms (HZ/2). And thanks for the test-config hints.
>
> drivers/s390/char/sclp_sdias.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks!
prev parent reply other threads:[~2015-05-30 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 14:50 [PATCH V2] s390/sclp: pass timeout as HZ independent value Nicholas Mc Guire
2015-05-30 11:45 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530114532.GB4218@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox