From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757989AbbE3UW0 (ORCPT ); Sat, 30 May 2015 16:22:26 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38344 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754422AbbE3UWS (ORCPT ); Sat, 30 May 2015 16:22:18 -0400 Date: Sat, 30 May 2015 22:22:53 +0200 From: Frans Klaver To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 43/98] include/uapi/linux/hdlc/ioctl.h: include linux/if.h Message-ID: <20150530202253.GD15645@bugger.home> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-44-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1433000370-19509-44-git-send-email-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2015 at 05:38:35PM +0200, Mikko Rapeli wrote: > Fixes userspace compiler error: > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/hdlc/ioctl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/hdlc/ioctl.h b/include/uapi/linux/hdlc/ioctl.h > index 04bc027..8bbee11 100644 > --- a/include/uapi/linux/hdlc/ioctl.h > +++ b/include/uapi/linux/hdlc/ioctl.h > @@ -1,6 +1,7 @@ > #ifndef __HDLC_IOCTL_H__ > #define __HDLC_IOCTL_H__ > > +#include > > #define GENERIC_HDLC_VERSION 4 /* For synchronization with sethdlc utility */ What's the point of this one if you break this circular dependency in patch 49? Are those in between related? Thanks, Frans