From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stefan Agner <stefan@agner.ch>
Cc: a.zummo@towertech.it, maitysanchayan@gmail.com,
shawn.guo@linaro.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH] rtc: snvs: fix wakealarm by call enable_irq_wake earlier
Date: Sat, 30 May 2015 22:53:03 +0200 [thread overview]
Message-ID: <20150530205303.GJ2185@piout.net> (raw)
In-Reply-To: <1432222175-30673-1-git-send-email-stefan@agner.ch>
Hi,
On 21/05/2015 at 17:29:35 +0200, Stefan Agner wrote :
> When entering suspend while an wakeup alarm is set, enable_set_wake
> should make sure that the RTC interrupt keep being enabled and the
> .irq_set_wake for the RTC interrupt get called. However, since the
> driver uses the suspend_noirq callback, the call to enable_irq_wake
> has been made after disabling the interrupts. While .irq_set_wake
> has been called properly, the interrupt remained disabled.
>
> Use the suspend callback to call enable_irq_wake early enough to
> ensure the RTC interrupt remains enabled.
>
> Fixes: 7654e9d4fd8f ("drivers/rtc/rtc-snvs: fix suspend/resume")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
I'm applying it after adding
Cc: <stable@vger.kernel.org> # 3.19
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-30 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 15:29 [PATCH] rtc: snvs: fix wakealarm by call enable_irq_wake earlier Stefan Agner
2015-05-30 20:53 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530205303.GJ2185@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox