From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
oen@telliq.com
Subject: Re: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
Date: Sat, 30 May 2015 23:56:34 +0200 [thread overview]
Message-ID: <20150530215634.GL2185@piout.net> (raw)
In-Reply-To: <1432795725-8350-1-git-send-email-jan.kardell@telliq.com>
On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote :
> Return -EINVAL if the voltage low bit is set to avoid getting a bogus
> time at boot.
> There was a comment stating that util-linux hwclock refuses to set a
> new time if we return an error code on read, but at least the current
> version do set the time as expected. Remove the comment and the check
> for valid time, and let the rtc core check it for us.
>
> Changes in v2: Remove the test for invalid time. Change dev_err to
> dev_info when voltage low is set.
>
> Changes in v3: Use dev_err when voltage low is set.
>
> Signed-off-by: Jan Kardell <jan.kardell@telliq.com>
> ---
> drivers/rtc/rtc-pcf8563.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-30 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 6:48 [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time Jan Kardell
2015-05-30 21:56 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530215634.GL2185@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dan.carpenter@oracle.com \
--cc=jan.kardell@telliq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oen@telliq.com \
--cc=rtc-linux@googlegroups.com \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox